Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GPO and add administrative templates #3965

Merged
merged 6 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions common/Helpers/GPOHelper.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

using Microsoft.Win32;
using Serilog;

namespace DevHome.Common.Helpers;

public class GPOHelper
{
private static readonly ILogger _log = Log.ForContext("SourceContext", nameof(GPOHelper));

private enum GpoRuleConfigured
{
WrongValue = -3, // The policy is set to an unrecognized value
Unavailable = -2, // Couldn't access registry
NotConfigured = -1, // Policy is not configured
Disabled = 0, // Policy is disabled
Enabled = 1, // Policy is enabled
}

// Registry path where gpo policy values are stored
private const string PoliciesScopeMachine = "HKEY_LOCAL_MACHINE";
private const string PoliciesPath = @"\SOFTWARE\Policies\DevHome";

// Registry value names
private const string PolicyConfigureEnabledDevHome = "ConfigureEnabledDevHome";

private static GpoRuleConfigured GetConfiguredValue(string registryValueName)
{
try
{
var rawValue = Registry.GetValue(
keyName: PoliciesScopeMachine + PoliciesPath,
valueName: registryValueName,
defaultValue: GpoRuleConfigured.NotConfigured);

_log.Error($"Registry value {registryValueName} set to {rawValue}");

// Value will be null if the subkey specified by keyName does not exist.
if (rawValue == null)
{
return GpoRuleConfigured.NotConfigured;
}
else if (rawValue is not int && rawValue is not GpoRuleConfigured)
{
return GpoRuleConfigured.WrongValue;
}
else
{
return (GpoRuleConfigured)rawValue;
}
}
catch (System.Security.SecurityException)
{
// The user does not have the permissions required to read from the registry key.
return GpoRuleConfigured.Unavailable;
}
catch (System.IO.IOException)
{
// The RegistryKey that contains the specified value has been marked for deletion.
return GpoRuleConfigured.Unavailable;
}
catch (System.ArgumentException)
{
// keyName does not begin with a valid registry root.
return GpoRuleConfigured.NotConfigured;
}
}

private static bool EvaluateConfiguredValue(string registryValueName, GpoRuleConfigured defaultValue)
{
var configuredValue = GetConfiguredValue(registryValueName);
if (configuredValue < 0)
{
krschau marked this conversation as resolved.
Show resolved Hide resolved
_log.Error($"Registry value {registryValueName} set to {configuredValue}, using default {defaultValue} instead.");
configuredValue = defaultValue;
}

return configuredValue == GpoRuleConfigured.Enabled;
}

public static bool GetConfiguredEnabledDevHomeValue()
{
var defaultValue = GpoRuleConfigured.Enabled;
return EvaluateConfiguredValue(PolicyConfigureEnabledDevHome, defaultValue);
}
}
6 changes: 6 additions & 0 deletions src/Strings/en-us/Resources.resw
Original file line number Diff line number Diff line change
Expand Up @@ -286,4 +286,10 @@
<data name="WidgetScreenshotAltDisplaySSKeychain" xml:space="preserve">
<value>SSH Keychain widget preview image</value>
</data>
<data name="GPODisabledDevHomeHeader.Text" xml:space="preserve">
<value>Dev Home is blocked</value>
</data>
<data name="GPODisabledDevHomeDescription.Text" xml:space="preserve">
<value>Check with your IT or System Administrator for support.</value>
</data>
</root>
9 changes: 9 additions & 0 deletions src/ViewModels/ShellViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ public partial class ShellViewModel : ObservableObject
[ObservableProperty]
private InfoBarModel _shellInfoBarModel = new();

[ObservableProperty]
private bool _isDevHomeGPOEnabled;

public ShellViewModel(
INavigationService navigationService,
INavigationViewService navigationViewService,
Expand All @@ -59,6 +62,12 @@ public void OnLoaded()
Log.Information($"Activated with kind {activationKind}");
TelemetryFactory.Get<ITelemetry>().Log("DevHome_Shell_Loaded_Event", LogLevel.Critical, new DevHomeShellLoadedEvent(activationKind));

IsDevHomeGPOEnabled = GPOHelper.GetConfiguredEnabledDevHomeValue();
if (!IsDevHomeGPOEnabled)
{
return;
}

switch (activationKind)
{
case ExtendedActivationKind.File:
Expand Down
22 changes: 21 additions & 1 deletion src/Views/ShellPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
xmlns:behaviors="using:DevHome.Common.Behaviors"
xmlns:i="using:Microsoft.Xaml.Interactivity"
xmlns:windows="using:DevHome.Common.Windows"
xmlns:converters="using:CommunityToolkit.WinUI.Converters"
Loaded="OnLoaded">
<Page.Resources>
<converters:BoolToVisibilityConverter x:Key="NegatedBoolToVisibilityConverter" TrueValue="Collapsed" FalseValue="Visible" />
</Page.Resources>

<Grid>
<Grid.RowDefinitions>
Expand All @@ -30,7 +34,8 @@
OpenPaneLength="350"
ExpandedModeThresholdWidth="1280"
DisplayModeChanged="NavigationViewControl_DisplayModeChanged"
Header="{x:Bind ((ContentControl)ViewModel.Selected).Content, Mode=OneWay}">
Header="{x:Bind ((ContentControl)ViewModel.Selected).Content, Mode=OneWay}"
Visibility="{x:Bind ViewModel.IsDevHomeGPOEnabled, Mode=OneWay}">
<NavigationView.Resources>
<ResourceDictionary>
<ResourceDictionary.ThemeDictionaries>
Expand Down Expand Up @@ -115,6 +120,21 @@
</Grid>
</NavigationView>

<StackPanel
Grid.Row="1"
HorizontalAlignment="Center"
VerticalAlignment="Center"
Visibility="{x:Bind ViewModel.IsDevHomeGPOEnabled, Mode=OneWay, Converter={StaticResource NegatedBoolToVisibilityConverter}}">
<TextBlock
x:Uid="GPODisabledDevHomeHeader"
Style="{StaticResource HeaderTextBlockStyle}"
HorizontalTextAlignment="Center"/>
<TextBlock
x:Uid="GPODisabledDevHomeDescription"
Style="{StaticResource SubheaderTextBlockStyle}"
HorizontalTextAlignment="Center"/>
</StackPanel>

<!-- A "hidden" TextBlock read by the narrator on value change.
Setting the visibility to Collapsed prevents the screen reader
from reading the control value. -->
Expand Down
32 changes: 32 additions & 0 deletions src/gpo/assets/DevHome.admx
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright (c) Microsoft Corporation.
Licensed under the MIT License. -->
<policyDefinitions xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" revision="0.1900" schemaVersion="1.0" xmlns="http://schemas.microsoft.com/GroupPolicy/2006/07/PolicyDefinitions">
<policyNamespaces>
<target prefix="devhome" namespace="Microsoft.Policies.DevHome" />
</policyNamespaces>
<resources minRequiredRevision="0.1900"/>
<supportedOn>
<definitions>
<definition name="SUPPORTED_DEVHOME_0_1900" displayName="$(string.SUPPORTED_DEVHOME_0_1900)"/>
</definitions>
</supportedOn>
<categories>
<category name="DevHome" displayName="$(string.DevHome)" />
</categories>

<policies>

<!--The name (id) of the policy is different from the valueName to sort it as first policy in edit dialog. The order is sorted alphabetically based on the "name" property.-->
<policy name="ConfigureAllDevHomeEnabledState" class="Both" displayName="$(string.ConfigureAllDevHomeEnabledState)" explainText="$(string.ConfigureAllDevHomeEnabledStateDescription)" key="Software\Policies\DevHome" valueName="ConfigureEnabledDevHome">
<parentCategory ref="DevHome" />
<supportedOn ref="SUPPORTED_DEVHOME_0_1901" />
<enabledValue>
<decimal value="1" />
</enabledValue>
<disabledValue>
<decimal value="0" />
</disabledValue>
</policy>
</policies>
</policyDefinitions>
29 changes: 29 additions & 0 deletions src/gpo/assets/en-US/DevHome.adml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright (c) Microsoft Corporation.
Licensed under the MIT License. -->
<policyDefinitionResources xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" revision="0.1900" schemaVersion="1.0" xmlns="http://schemas.microsoft.com/GroupPolicy/2006/07/PolicyDefinitions">
<displayName>Dev Home</displayName>
<description>Dev Home</description>
<resources>
<stringTable>
<string id="DevHome">Microsoft Dev Home</string>

<string id="SUPPORTED_DEVHOME_0_1900">Dev Home version 0.1900.* or later</string>

<string id="ConfigureAllDevHomeEnabledStateDescription">This policy configures the enabled state for Dev Home.

If you enable this setting, Dev Home will be always enabled and the user won't be able to disable it.

If you disable this setting, Dev Home will be always disabled and the user won't be able to enable it.

If you don't configure this setting, users are able to enable or disable Dev Home.

This policy will override any enabled state policies for individual Dev Home features.
</string>

<string id="ConfigureAllDevHomeEnabledState">Configure Dev Home enabled state</string>
</stringTable>

</resources>
</policyDefinitionResources>

Loading