Update creation so Dev Home no longer brings up the wsl.exe window during creation #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to install and register wsl distributions.
bbonaby
requested review from
dhoehna,
jsidewhite,
vineeththomasalex,
safmswork,
krschau,
sshilov7,
SohamDas2021,
AmelBawa-msft and
huzaifa-d
krschau
approved these changes
Sep 6, 2024
Co-authored-by: Kristen Schau <[email protected]>
kanismohammed
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This is a follow up PR to #3743 . Before that change we were using
wsl.exe --install <distribution name>to both install the WSL kernel package, and the distribution the user selected. Now, after this change the WSL extension itself will install the WSL kernel package from the store, but we still let wsl.exe do the downloading, installing and registering of the distribution package from the store. With this change all three of those tasks will now be done by the WSL extension. This provides us better flexibility and the user no longer sees a disconnected terminal Window outside of Dev Home. Everything from downloading, installing and registering the distribution will happen within Dev Home itself.Here is a video of me installing the Debian distribution BEFORE my changes
video.showing.me.install.the.debian.distribution.from.current.dev.build.mp4
Here is a video of me installing the Debian distribution AFTER my changes
Video.of.me.installing.and.registering.the.debian.distribution.without.the.terminal.window.popping.up.mp4
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist