Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize cancellation token in DashboardView constructor #3648

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Initialize cancellation token in DashboardView constructor #3648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b056c1
Initialize initWidgetsCancellationTokenSource in constructor
krschau Aug 20, 2024
883e029
simplify initialization
krschau Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tools/Dashboard/DevHome.Dashboard/Views/DashboardView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public partial class DashboardView : ToolPage, IDisposable
private static DispatcherQueue _dispatcherQueue;
private readonly ILocalSettingsService _localSettingsService;
private readonly IWidgetExtensionService _widgetExtensionService;
private CancellationTokenSource _initWidgetsCancellationTokenSource;
private readonly CancellationTokenSource _initWidgetsCancellationTokenSource = new();
private bool _disposedValue;

private const string DraggedWidget = "DraggedWidget";
Expand Down Expand Up @@ -206,7 +206,6 @@ private async Task InitializeDashboard()
await _localSettingsService.SaveSettingAsync(WellKnownSettingsKeys.IsNotFirstDashboardRun, true);
}

_initWidgetsCancellationTokenSource = new();
try
{
await InitializePinnedWidgetListAsync(isFirstDashboardRun, _initWidgetsCancellationTokenSource.Token);
Expand Down
Loading