Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a dialog to the user when app execution alias is disabled and want to run PI as admin #3172

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Show a dialog to the user when app execution alias is disabled and want to run PI as admin #3172

merged 9 commits into from
Jun 10, 2024

Conversation

zadesai
Copy link
Contributor

@zadesai zadesai commented Jun 7, 2024 •
edited
Loading

Summary of the pull request

When the user wants to run PI as admin and alias is disabled, show a content dialog to the user to enable alias from settings app.

Validation steps performed

  1. Launch PI

  2. Disable alias for PI

  3. attach to task manager

  4. click on the Run as admin button

  5. See the dialog
    image

  6. Click on Go to Advanced apps settings

  7. Go to alias page and enable Project Ironside

  8. Click Run as admin button again on PI and confirmed PI launches as admin.

PR checklist

jaholme
jaholme approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@jaholme jaholme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zadesai zadesai merged commit a367992 into main Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krschau krschau krschau left review comments

@vineeththomasalex vineeththomasalex vineeththomasalex left review comments

@dhoehna dhoehna dhoehna left review comments

@andreww-msft andreww-msft andreww-msft approved these changes

@jaholme jaholme jaholme approved these changes

@timkur timkur Awaiting requested review from timkur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix crash when not running elevated
6 participants
@zadesai @dhoehna @vineeththomasalex @jaholme @andreww-msft @krschau