Fix issues with DPI scaling that were making PI offcenter and too large #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaholme
requested review from
timkur,
andreww-msft,
aeloros,
dabhattimsft and
zadesai
dhoehna
reviewed
Jun 7, 2024
andreww-msft
approved these changes
Jun 7, 2024
…/jaholme/dpi_issues
dhoehna
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
In some places we were multiplying raw pixel values by the dpiscale, this was resulting in values that were too large causing PI not to come up centered on the monitor.
The defaults for expanded view were assigning raw device pixel values to the window Width which are device independent pixels and need to be scaled by the monitors scale factor.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Clean installed Devhome, deleting any PI user.config files found under C:\Users*\AppData\Local\Microsoft_Corporation\DevHome.PI**\user.config to reset the expanded view saved values.
On a device with 150% scale factor PI is now launched centered and the expanded view doesn't exceed the bounds of the monitor.
PR checklist