Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Build Fix #3169

Conversation

ssparach
Copy link
Contributor

@ssparach ssparach commented Jun 6, 2024

Summary of the pull request

Enable nullable property in relevant classes

References and relevant issues

Detailed description of the pull request / Additional comments

Resolves below errors observed in CI builds:
"D:\a\devhome\devhome\DevHome.sln" (default target) (1) ->
"D:\a\devhome\devhome\src\DevHome.csproj.metaproj" (default target) (2) ->
"D:\a\devhome\devhome\src\DevHome.csproj" (default target) (11) ->
"D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj" (default target) (15:2) ->
(CoreCompile target) ->
D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\Services\RepositoryTracking.cs(32,80): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj]
D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\Services\RepositoryTracking.cs(34,37): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj]
D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\Services\RepoStoreOptions.cs(20,19): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj]

Validation steps performed

Local Builds (both VS and using build script in Developer Command Prompt to build msix release) are successful

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@ssparach ssparach requested a review from DefaultRyan June 6, 2024 23:16
@ssparach ssparach merged commit 118ce27 into feature/fileexplorer-sourcecontrol-integration Jun 7, 2024
1 of 4 checks passed
ssparach added a commit that referenced this pull request Jul 31, 2024
* fix

* move nullable property in csproj

* fix format
ssparach added a commit that referenced this pull request Jul 31, 2024
* fix

* move nullable property in csproj

* fix format
ssparach added a commit that referenced this pull request Jul 31, 2024
* fix

* move nullable property in csproj

* fix format
@ssparach ssparach deleted the user/ssparach/CIBuildFix branch August 2, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants