-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring winget/dsc services out of UI projects #3134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/amelbawa/services
…/amelbawa/services
AmelBawa-msft
requested review from
dkbennett,
bbonaby,
manodasanW,
dhoehna,
vineeththomasalex,
krschau and
EricJohnson327
June 13, 2024 20:43
krschau
reviewed
Jun 13, 2024
AmelBawa-msft
changed the title
Refactoring winget services out of UI projects
Refactoring winget/dsc services out of UI projects
Jun 14, 2024
You might want to rebase instead of merge... looks like your PR has pulled in previous changes, making it harder to see what changed here. |
dhoehna
approved these changes
Jun 21, 2024
krschau
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest moving new stuff under Common in a separate change.
Also, you might want to create Debug_FailFast configs for the new projects
4 tasks
…/amelbawa/services
vineeththomasalex
approved these changes
Jun 26, 2024
This was referenced Jul 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
References and relevant issues
IAppInstallManagerService
toIMicrosoftStoreService
IWindowsPackageManager
toIWinGet
Microsoft.Extensions.Logging.ILogger
instead ofSerilog.ILogger
inDevHome.Services.*
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist