Allow widgets to take foreground rights on user interaction #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
dhoehna,
guimafelipe,
dkbennett,
EricJohnson327 and
AmelBawa-msft
guimafelipe
approved these changes
Jun 4, 2024
jaholme
reviewed
Jun 4, 2024
| // CoAllowSetForegroundWindow must be called on a raw COM interface, not a .NET CCW, in order to work correctly, since | ||
| // the underlying functionality is implemented by COM runtime and the object itself. CoAllowSetForegroundWindow wrapper | ||
| // below takes a WinRT object and extracts the raw COM interface pointer from it before calling native CoAllowSetForegroundWindow. | ||
| [DllImport("ole32.dll", ExactSpelling = true, PreserveSig = false, SetLastError = true)] |
There was a problem hiding this comment.
+1. But checking this in now for Canary this week.
EricJohnson327
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Various widgets launch UI, and it is a problem when they can't launch to the foreground because they don't have foreground rights. When a user interacts with a widget, we notify the widget of that interaction (so they can respond to it) via the
Widget.NotifyActionInvokedAsync()API. Before we call that API, we should give the widget process foreground rights, so they can take them and launch to the foreground if they choose.References and relevant issues
#2747
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist