-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdditionalTools validation & feedback #3108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreww-msft
requested review from
jaholme,
timkur,
zadesai and
aeloros
and removed request for
jaholme and
timkur
June 4, 2024 01:31
I edited your description with the magic syntax so GitHub would link everything together. Now when this closes, the issues it fixes will close. |
krschau
reviewed
Jun 4, 2024
jaholme
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dhoehna
reviewed
Jun 4, 2024
dhoehna
reviewed
Jun 4, 2024
dhoehna
reviewed
Jun 4, 2024
dhoehna
reviewed
Jun 4, 2024
dhoehna
reviewed
Jun 4, 2024
zadesai
reviewed
Jun 4, 2024
zadesai
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
krschau
reviewed
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
In Settings | Additional Tools, ensure the toolpath and name are valid, and provide user feedback when registering a tool (via a new timed message dialog in WindowHelper). Also only enable the Unregister button if the user selects at least one tool (and enable unregistering multiple tools at once).
Also, added tooltips to all the fields on the App Details page; suppress the external tools menuflyout if there are no external tools; and fixed the pin/unpin menu icon.
References and relevant issues
Fixed the following: