Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdditionalTools validation & feedback #3108

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Conversation

andreww-msft
Copy link
Contributor

@andreww-msft andreww-msft commented Jun 4, 2024

Summary of the pull request

In Settings | Additional Tools, ensure the toolpath and name are valid, and provide user feedback when registering a tool (via a new timed message dialog in WindowHelper). Also only enable the Unregister button if the user selects at least one tool (and enable unregistering multiple tools at once).

Also, added tooltips to all the fields on the App Details page; suppress the external tools menuflyout if there are no external tools; and fixed the pin/unpin menu icon.

References and relevant issues

Fixed the following:

@andreww-msft andreww-msft requested review from jaholme, timkur, zadesai and aeloros and removed request for jaholme and timkur June 4, 2024 01:31
@krschau
Copy link
Collaborator

krschau commented Jun 4, 2024

I edited your description with the magic syntax so GitHub would link everything together. Now when this closes, the issues it fixes will close.

Copy link
Contributor

@jaholme jaholme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@zadesai zadesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andreww-msft andreww-msft merged commit 0c4fb00 into main Jun 4, 2024
4 checks passed
@andreww-msft andreww-msft deleted the user/andreww/addTools branch June 4, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment