Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI: Winlogs - Do not reset the check/uncheck state of checkbox, if the user has changed it. #3105

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

zadesai
Copy link
Contributor

@zadesai zadesai commented Jun 3, 2024

Summary of the pull request

Bug: If the user checked/unchecked one of the logs checkbox in Winlogs page -> Then go to a different page-> go back to winlogs page, the checkboxes are reset and we do not maintain the state.
Fix:

  1. Store the checkbox status in the viewmodel to make sure the same logs are enabled/disabled when the user goes back to Winlogs page.
  2. Also, enable NavigationCacheMode on all main pages to avoid creating new instances of Page everytime a user navigates in and out of it.

Validation steps performed

  1. Attach PI to an app
  2. Go to winlogs page
  3. Unselect EventViewer and select debugoutput
  4. go to any other page
  5. Go back to winlogs page and made sure EventViewer is not selected and DebugOutput was selected.

PR checklist

Copy link
Contributor

@timkur timkur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jaholme
Copy link
Contributor

jaholme commented Jun 4, 2024

                    RunAsAdminVisibility = Visibility.Visible;

should we set the enablement of the etw logs toggle to false here?


Refers to: tools/PI/DevHome.PI/ViewModels/WinLogsPageViewModel.cs:104 in 75c4f67. [](commit_id = 75c4f67, deletion_comment = False)

Copy link
Contributor

@jaholme jaholme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zadesai
Copy link
Contributor Author

zadesai commented Jun 4, 2024

                    RunAsAdminVisibility = Visibility.Visible;

We stop Winlogs before we reach here and also collapse the GridVisibility, so etw logs toggle value will not matter


In reply to: 2146328445


Refers to: tools/PI/DevHome.PI/ViewModels/WinLogsPageViewModel.cs:104 in 75c4f67. [](commit_id = 75c4f67, deletion_comment = False)

@zadesai zadesai merged commit 61883c4 into main Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Windows logs log page > items are toggled/untoggled when returning to the page
3 participants