Adding automation properties. Moving some code to the view model. #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabhattimsft
reviewed
Jun 3, 2024
| /// then user is on. | ||
| /// </summary> | ||
| /// <param name="searchTerms">The search terms for repositories.</param> | ||
| /// <returns>True if the close should be canceled. Otherwise false and the dialog will close.</returns> |
There was a problem hiding this comment.
Nit:
Suggested change
| /// <returns>True if the close should be canceled. Otherwise false and the dialog will close.</returns> | |
| /// <returns>True if the close should be canceled. Otherwise false and the dialog will close.</returns> | |
vineeththomasalex
approved these changes
Jun 5, 2024
EricJohnson327
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The sync button in the environments page did not have an accessible name. Added that.
Moved the code that handles the primary button click on the Add Repo Dialog to the view model.
References and relevant issues
https://task.ms/49696271
Detailed description of the pull request / Additional comments
Validation steps performed
For the sync button, tested with narrator.
For the add repo dialog.
PR checklist