Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI: Expand new insight when added from winlogs page #3098

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

zadesai
Copy link
Contributor

@zadesai zadesai commented Jun 3, 2024

References and relevant issues

When you create a new insight this doesn't open the insight expander

Detailed description of the pull request / Additional comments

When a new insight is added from winlogs page, and the user goes to Insights page using the Insights button, we should show all details about the new insight and set IsExpanded as true.

Validation steps performed

  1. Launch PI
  2. Attach to process
  3. Go to Winlogs page
  4. Trigger a log which adds a new insight
  5. Go to Insights page and see that the Expander is in expanded state.

PR checklist

@zadesai zadesai changed the title Expand new insight when added from winlogs page PI: Expand new insight when added from winlogs page Jun 3, 2024
Copy link
Contributor

@timkur timkur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@jaholme jaholme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zadesai zadesai merged commit 1729df9 into main Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When you create a new insight this doesn't open the insight expander
3 participants