Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Settings to be a regular page, not a free-floating window #3018

Merged
merged 2 commits into from
May 31, 2024

Conversation

andreww-msft
Copy link
Contributor

Summary

Before this, PI Settings were provided in a separate free-floating window. This change moves PI Settings into the main window as a page, using the same basic navigation model as Dev Home Settings.

Details

This meant creating a new viewmodel and page for the main settings UI, and for each of the 4 sub-pages, and registering these with the navigation service and page service. Per Dev Home model, moved the various UI event handlers to command-binding with RelayCommands in the viewmodel (although I mostly left the AdditionalTools page alone after the port, because we have a backlog item to redesign this piece anyway).

Reimplemented all the Settings sub-pages to match Dev Home's model: moved custom border items to SettingsCards, SettingsExpanders and so on. Added simple breadcrumb navigation. Created PIAppInfoService, which is a subset of Dev Home's AppInfoService. Deleted the old SettingsToolWindow & ToolWindow classes, moved the AddTools and EditTools controls to the Controls folder/namespace and deleted the SettingsUi folder.

In the ExpandedView, moved the Settings button to the bottom of the left nav-list, and reworked the grid layout to ensure Settings is at the bottom regardless of whether there's a perf counter row. Deleted the SettingsNavLink class as its now redundant. Note that the main PI nav mechanism is different from Dev Home's main nav model, and we have a backlog item to update this to a NavigationView.

Here's the main Settings page in the PI expanded view:

PI-settings-main

Breadcrumbs and page navigation...

PI-settings-breadcrumbs

@andreww-msft andreww-msft self-assigned this May 30, 2024
@krschau krschau added this to the Dev Home 0.15 milestone May 30, 2024
Copy link
Contributor

@zadesai zadesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@jaholme jaholme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andreww-msft andreww-msft merged commit 4a49480 into main May 31, 2024
4 checks passed
@andreww-msft andreww-msft deleted the user/andreww/settingsPage branch May 31, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants