-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved Settings to be a regular page, not a free-floating window #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadesai
reviewed
May 30, 2024
zadesai
reviewed
May 30, 2024
zadesai
reviewed
May 30, 2024
zadesai
reviewed
May 30, 2024
zadesai
reviewed
May 30, 2024
zadesai
reviewed
May 30, 2024
zadesai
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jaholme
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this, PI Settings were provided in a separate free-floating window. This change moves PI Settings into the main window as a page, using the same basic navigation model as Dev Home Settings.
Details
This meant creating a new viewmodel and page for the main settings UI, and for each of the 4 sub-pages, and registering these with the navigation service and page service. Per Dev Home model, moved the various UI event handlers to command-binding with RelayCommands in the viewmodel (although I mostly left the AdditionalTools page alone after the port, because we have a backlog item to redesign this piece anyway).
Reimplemented all the Settings sub-pages to match Dev Home's model: moved custom border items to SettingsCards, SettingsExpanders and so on. Added simple breadcrumb navigation. Created PIAppInfoService, which is a subset of Dev Home's AppInfoService. Deleted the old SettingsToolWindow & ToolWindow classes, moved the AddTools and EditTools controls to the Controls folder/namespace and deleted the SettingsUi folder.
In the ExpandedView, moved the Settings button to the bottom of the left nav-list, and reworked the grid layout to ensure Settings is at the bottom regardless of whether there's a perf counter row. Deleted the SettingsNavLink class as its now redundant. Note that the main PI nav mechanism is different from Dev Home's main nav model, and we have a backlog item to update this to a NavigationView.
Here's the main Settings page in the PI expanded view:
Breadcrumbs and page navigation...