Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Home PI: Close target process Performance counters when the target process exits #2960

Merged
merged 1 commit into from
May 17, 2024

Conversation

zadesai
Copy link
Contributor

@zadesai zadesai commented May 17, 2024

Detailed description of the pull request / Additional comments

Bug: Performance counters continue running after the target process has exited.
Fix: When target process HasExited property changes, close all Performance counters for the target process.

Validation steps performed

  1. Launch PI from Dev Home utilities and target to any app
  2. Expand the window to see all pages
  3. go to "Resource usage" page
  4. Close the app that we are targeting.
  5. Validate that the resource usage goes down to 0.

counter.Dispose();
}

gpuCounters?.Clear();

readCounter?.Close();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe a helper to close, dispose and null?

@zadesai zadesai merged commit 7830239 into main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants