Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Home PI: Close the settings window when the Bar Window is closed #2957

Merged
merged 1 commit into from
May 17, 2024

Conversation

zadesai
Copy link
Contributor

@zadesai zadesai commented May 17, 2024

Summary of the pull request

SettingsToolWindow is not closed when the user closes the bar window currently. Added a fix to call SettingsToolWindow.Close when the barwindow is closed.

Validation steps performed

  1. Launch DevHome.PI from Utilities
  2. Click on Expand button
  3. Click on Settings icon at the bottom right
  4. Go back to bar window
  5. Click on close icon on the top right
  6. Verified that the settings window closes along with bar window

@zadesai zadesai merged commit 5001b95 into main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants