Update Utilities page design to align with designer feedback #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
reviewed
May 14, 2024
dhoehna
reviewed
May 14, 2024
dhoehna
reviewed
May 14, 2024
dhoehna
reviewed
May 14, 2024
dhoehna
reviewed
May 14, 2024
dhoehna
reviewed
May 14, 2024
dhoehna
reviewed
May 14, 2024
| HorizontalAlignment="Center" | ||
| IsOn="{x:Bind ViewModel.LaunchAsAdmin, Mode=TwoWay}" | ||
| Visibility="{x:Bind ViewModel.LaunchAsAdminVisibility, Mode=OneWay}" | ||
| OnContent="Launch as administrator" |
There was a problem hiding this comment.
Both On and Off use the same content? This tells me that the program will still launch as admin even when toggled off.
There was a problem hiding this comment.
To me, it is like - turn it on to launch as admin. i.e. to me, the text doesn't represent the current state of the switch but what would happen if turn it on.
dhoehna
reviewed
May 14, 2024
nieubank
approved these changes
May 15, 2024
jaholme
approved these changes
May 15, 2024
vineeththomasalex
approved these changes
May 15, 2024
dabhattimsft
force-pushed
the
user/dabhatti/utilitiesDesign
branch
from
f921f07 to
a9c6053
Compare
EricJohnson327
pushed a commit
that referenced
this pull request
May 16, 2024
* strings and url * visibility * pr feedback * pr feedback * string and icon * merge conflict --------- Co-authored-by: Darshak Bhatti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR updates design of utilities page to remove the split button and add a toggle for admin launch. This change also updates descriptions to strings written by the content writer and links to go links instead of aka.ms.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Manually validated
PR checklist