Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links on Dev Drive insights #2803

Merged
merged 3 commits into from
May 3, 2024
+13 −10
Merged

Fix links on Dev Drive insights #2803

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf37d64
Remove broken link, add new learn more link on package caches
SohamDas2021 May 3, 2024
6b2e3dd
Addressed PR comments
SohamDas2021 May 3, 2024
78de7d2
Addressed PR comments
SohamDas2021 May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tools/Customization/DevHome.Customization/Strings/en-us/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,13 @@
<comment>Optimizer dev drive description when environment variable is not set</comment>
</data>
<data name="PackageCachesDescription.Text" xml:space="preserve">
<value>A package cache is the global folder location used by an application to store files for installed software. These source files are needed when you want to update, uninstall, or repair the installed software. Visual Studio is one such application that stores a large portion of its data in the Package Cache.</value>
<value>A package cache is the global folder location used by an application to store files for installed software. These source files are needed when you want to update, uninstall, or repair the installed software. Visual Studio is one such application that stores a large portion of its data in the Package Cache. To learn more about configuring your package caches see </value>
<comment>Package caches description</comment>
</data>
<data name="PackageCachesLearnMoreLink.Text" xml:space="preserve">
<value>Set up a Dev Drive on Windows 11 | Microsoft Learn</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can probably call this "Storing package caches on Dev Drive volumes", as it better reflects the link you posted below

<comment>Package caches hyperlink text</comment>
</data>
<data name="SettingsAutoSuggestBox.PlaceholderText" xml:space="preserve">
<value>Search</value>
<comment>The placholder text for the settings auto suggest box</comment>
Expand Down
17 changes: 8 additions & 9 deletions tools/Customization/DevHome.Customization/Views/DevDriveInsightsView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,9 @@
IsTextSelectionEnabled="True"/>
</Grid>
<ctControls:SettingsExpander.Items>
<ctControls:SettingsCard Description="{Binding Path=OptimizerDevDriveDescription, Mode=OneWay}">
<ctControls:SettingsCard Padding="60 10 20 15" Description="{Binding Path=OptimizerDevDriveDescription, Mode=OneWay}">
<Button x:Name="OptimizerDialogLauncher" Content="{x:Bind MakeTheChangeText, Mode=OneWay}" Command="{Binding OptimizeDevDriveCommand}" CommandParameter="{Binding ElementName=OptimizerDialogLauncher}"/>
</ctControls:SettingsCard>
<ctControls:SettingsCard Header="{Binding Path=CacheToBeMoved, Mode=OneWay}" Foreground="{ThemeResource HyperlinkButtonForeground}"/>
</ctControls:SettingsCard>
</ctControls:SettingsExpander.Items>
</ctControls:SettingsExpander>
</DataTemplate>
Expand Down Expand Up @@ -152,12 +151,12 @@
Style="{StaticResource CardBodyStackPanelTextBlockStyle}"
Text="Package Caches"
IsTextSelectionEnabled="True"/>
<TextBlock
Margin="0 10 0 0"
Style="{StaticResource CardBodyStackPanelAltTextBlockStyle}"
x:Uid ="PackageCachesDescription"
IsTextSelectionEnabled="True"
TextWrapping="WrapWholeWords"/>
<TextBlock Margin="0 10 0 0" Style="{StaticResource CardBodyStackPanelAltTextBlockStyle}" TextWrapping="WrapWholeWords">
<Run x:Uid="PackageCachesDescription"/>
<Hyperlink NavigateUri="https://learn.microsoft.com/en-us/windows/dev-drive/#storing-package-cache-on-dev-drive">
SohamDas2021 marked this conversation as resolved.
Show resolved Hide resolved
<Run x:Uid="PackageCachesLearnMoreLink" />
</Hyperlink>
</TextBlock>
<!--- List of DevDriveOptimizersListViewModel objects. -->
<ListView
x:Name="DevDriveOptimizersList"
Expand Down
Loading