Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select app version to install #2272

Merged
merged 17 commits into from
Feb 21, 2024
Merged

Select app version to install #2272

merged 17 commits into from
Feb 21, 2024

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Feb 16, 2024 •
edited
Loading

Summary of the pull request

  • Allow user to specify the package version to install/upgrade
  • Replaced Uri with a new custom class WinGetPackageUri
x-ms-winget://winget/Microsoft.VisualStudioCode?version=1.86.2
|  Scheme  | Catalog |        Package ID       | Package options
  • Add Unit Test

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

image
image

PR checklist

@AmelBawa-msft AmelBawa-msft marked this pull request as ready for review February 20, 2024 17:30
@AmelBawa-msft AmelBawa-msft added the Needs-Second Pull request that needs another approval label Feb 20, 2024
@AmelBawa-msft AmelBawa-msft merged commit bebb21c into main Feb 21, 2024
4 checks passed
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa-msft/support-app-version branch February 21, 2024 18:58
@krschau krschau removed the Needs-Second Pull request that needs another approval label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkbennett dkbennett dkbennett approved these changes

@dhoehna dhoehna dhoehna approved these changes

@manodasanW manodasanW Awaiting requested review from manodasanW

@vineeththomasalex vineeththomasalex Awaiting requested review from vineeththomasalex

@krschau krschau Awaiting requested review from krschau

@EricJohnson327 EricJohnson327 Awaiting requested review from EricJohnson327

@bbonaby bbonaby Awaiting requested review from bbonaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add version selection for installing applications
4 participants
@AmelBawa-msft @dhoehna @dkbennett @krschau