Update Dev Insights to final Dev Diagnostics name (#3738)

* Update Dev Insights to final Dev Diagnostics name

* Fixes per PR comments

* Resetting doNotLaunchApp to false

* Fix bad merge

* Fixed rename straggler in comment.

DevHome.sln

@@ -122,9 +122,9 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DevSetupAgent.Test", "exten
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "HyperVExtension.HostGuestCommunication", "extensions\HyperVExtension\src\HyperVExtension.HostGuestCommunication\HyperVExtension.HostGuestCommunication.csproj", "{D759CD66-494C-4A00-8075-8B65A9891349}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DevHome.DevInsights", "tools\DevInsights\DevHome.DevInsights\DevHome.DevInsights.csproj", "{CAAC0CDF-9AB8-4F43-A3EB-38D785AF5725}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DevHome.DevDiagnostics", "tools\DevDiagnostics\DevHome.DevDiagnostics\DevHome.DevDiagnostics.csproj", "{CAAC0CDF-9AB8-4F43-A3EB-38D785AF5725}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "DevInsights", "DevInsights", "{DB3D0F2C-1A7F-44B4-B408-B21A56212985}"
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "DevDiagnostics", "DevDiagnostics", "{DB3D0F2C-1A7F-44B4-B408-B21A56212985}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Customization", "Customization", "{623998FD-B0A6-4980-95D5-A5072301CA10}"
 EndProject
@@ -181,9 +181,9 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Devhome.Service.IDL", "serv
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "TestTools", "TestTools", "{7857275B-7970-4C26-B092-FF62EA890B1E}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestDumpAnalyzer", "tools\DevInsights\TestTools\TestDumpAnalyzer\TestDumpAnalyzer.csproj", "{29963C5C-4CB6-4406-850A-99503CB87081}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestDumpAnalyzer", "tools\DevDiagnostics\TestTools\TestDumpAnalyzer\TestDumpAnalyzer.csproj", "{29963C5C-4CB6-4406-850A-99503CB87081}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestServiceCaller", "tools\DevInsights\TestTools\TestServiceCaller\TestServiceCaller.csproj", "{024CB70C-3449-4204-9171-A25C6C25783D}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestServiceCaller", "tools\DevDiagnostics\TestTools\TestServiceCaller\TestServiceCaller.csproj", "{024CB70C-3449-4204-9171-A25C6C25783D}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DevHome.Database", "database\DevHome.Database\DevHome.Database.csproj", "{01CADE81-7333-4E24-A39B-95B7E58D4503}"
 EndProject

settings/DevHome.Settings/Strings/en-us/Resources.resw

@@ -553,13 +553,13 @@
     <value>Quiet background processes allows you to free up resources while developing</value>
     <comment>Inline description of the Quiet background processes experimental feature on the 'Settings -&gt; Experiments' page where you enable it.</comment>
   </data>
-  <data name="DevInsightsExperiment_Name" xml:space="preserve">
-    <value>Dev Insights</value>
-    <comment>Name of experimental feature 'Dev Insights' on the 'Settings -&gt; Experiments' page where you enable it.</comment>
+  <data name="DevDiagnosticsExperiment_Name" xml:space="preserve">
+    <value>Dev Diagnostics</value>
+    <comment>Name of experimental feature 'Dev Diagnostics' on the 'Settings -&gt; Experiments' page where you enable it.</comment>
   </data>
-  <data name="DevInsightsExperiment_Description" xml:space="preserve">
-    <value>Dev Insights is a utility to provide deeper insights into your applications</value>
-    <comment>Inline description of the Dev Insights experimental feature on the 'Settings -&gt; Experiments' page where you enable it.</comment>
+  <data name="DevDiagnosticsExperiment_Description" xml:space="preserve">
+    <value>Dev Diagnostics is a utility to provide deeper insights into your applications</value>
+    <comment>Inline description of the Dev Diagnostics experimental feature on the 'Settings -&gt; Experiments' page where you enable it.</comment>
   </data>
   <data name="QuickstartPlayground_Name" xml:space="preserve">
     <value>Quickstart Playground</value>

src/DevHome.csproj

@@ -95,7 +95,7 @@
     <ProjectReference Include="..\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj" />
     <ProjectReference Include="..\tools\Dashboard\DevHome.Dashboard\DevHome.Dashboard.csproj" />
     <ProjectReference Include="..\tools\Experiments\src\DevHome.Experiments.csproj" />
-    <ProjectReference Include="..\tools\DevInsights\DevHome.DevInsights\DevHome.DevInsights.csproj" />
+    <ProjectReference Include="..\tools\DevDiagnostics\DevHome.DevDiagnostics\DevHome.DevDiagnostics.csproj" />
     <ProjectReference Include="..\tools\QuietBackgroundProcesses\DevHome.QuietBackgroundProcesses.ElevatedServer.Projection\DevHome.QuietBackgroundProcesses.ElevatedServer.Projection.csproj" />
     <ProjectReference Include="..\tools\QuietBackgroundProcesses\DevHome.QuietBackgroundProcesses.ElevatedServer\DevHome.QuietBackgroundProcesses.ElevatedServer.vcxproj" />
     <ProjectReference Include="..\tools\QuietBackgroundProcesses\DevHome.QuietBackgroundProcesses.PerformanceRecorderEngine\DevHome.QuietBackgroundProcesses.PerformanceRecorderEngine.vcxproj" />

src/NavConfig.jsonc

@@ -132,7 +132,7 @@
       }
     },
     {
-      "identity": "DevInsightsExperiment",
+      "identity": "DevDiagnosticsExperiment",
       "enabledByDefault": false,
       "buildTypeOverrides": [
         {

src/Package-Can.appxmanifest

@@ -350,19 +350,19 @@
 
       </Extensions>
     </Application>
-    <Application Id="Devhome.DevInsights" Executable="DevHome.DevInsights.exe" EntryPoint="Windows.FullTrustApplication">
-      <uap:VisualElements DisplayName="ms-resource:DIDisplayName" Description="ms-resource:DIAppDescription" BackgroundColor="transparent" Square150x150Logo="Assets\Square150x150Logo.png" Square44x44Logo="Assets\Square44x44Logo.png" AppListEntry="none">
+    <Application Id="Devhome.DevDiagnostics" Executable="DevHome.DevDiagnostics.exe" EntryPoint="Windows.FullTrustApplication">
+      <uap:VisualElements DisplayName="ms-resource:DDDisplayName" Description="ms-resource:DDAppDescription" BackgroundColor="transparent" Square150x150Logo="Assets\Square150x150Logo.png" Square44x44Logo="Assets\Square44x44Logo.png" AppListEntry="none">
         <uap:DefaultTile Wide310x150Logo="Assets\Wide310x150Logo.png" />
         <uap:SplashScreen Image="Assets\SplashScreen.png" />
       </uap:VisualElements>
       <Extensions>
         <!-- Limitations in Microsoft.Extension.Configuration require this to be a key=value pair.-->
         <uap5:Extension Category="windows.startupTask" uap10:Parameters="/startuptask=true">
-          <uap5:StartupTask TaskId="DevHome.DevInsights.Hotkey" Enabled="true" DisplayName="ms-resource:DIStartupTaskDisplayName" />
+          <uap5:StartupTask TaskId="DevHome.DevDiagnostics.Hotkey" Enabled="true" DisplayName="ms-resource:DDStartupTaskDisplayName" />
         </uap5:Extension>
-        <uap3:Extension Category="windows.appExecutionAlias" Executable="DevHome.DevInsights.exe" EntryPoint="Windows.FullTrustApplication" uap10:RuntimeBehavior="packagedClassicApp" uap10:TrustLevel="mediumIL">
+        <uap3:Extension Category="windows.appExecutionAlias" Executable="DevHome.DevDiagnostics.exe" EntryPoint="Windows.FullTrustApplication" uap10:RuntimeBehavior="packagedClassicApp" uap10:TrustLevel="mediumIL">
           <uap3:AppExecutionAlias>
-            <desktop:ExecutionAlias Alias="devhome.devinsights.exe" />
+            <desktop:ExecutionAlias Alias="devhome.devdiagnostics.exe" />
           </uap3:AppExecutionAlias>
         </uap3:Extension>
       </Extensions>

src/Package-Dev.appxmanifest

@@ -346,19 +346,19 @@
         </com2:Extension>
       </Extensions>
     </Application>
-    <Application Id="Devhome.DevInsights" Executable="DevHome.DevInsights.exe" EntryPoint="Windows.FullTrustApplication">
-      <uap:VisualElements DisplayName="ms-resource:DIDisplayName" Description="ms-resource:DIAppDescription" BackgroundColor="transparent" Square150x150Logo="Assets\Square150x150Logo.png" Square44x44Logo="Assets\Square44x44Logo.png" AppListEntry="none">
+    <Application Id="Devhome.DevDiagnostics" Executable="DevHome.DevDiagnostics.exe" EntryPoint="Windows.FullTrustApplication">
+      <uap:VisualElements DisplayName="ms-resource:DDDisplayName" Description="ms-resource:DDAppDescription" BackgroundColor="transparent" Square150x150Logo="Assets\Square150x150Logo.png" Square44x44Logo="Assets\Square44x44Logo.png" AppListEntry="none">
         <uap:DefaultTile Wide310x150Logo="Assets\Wide310x150Logo.png" />
         <uap:SplashScreen Image="Assets\SplashScreen.png" />
       </uap:VisualElements>
       <Extensions>
         <!-- Limitations in Microsoft.Extension.Configuration require this to be a key=value pair.-->
         <uap5:Extension Category="windows.startupTask" uap10:Parameters="/startuptask=true">
-          <uap5:StartupTask TaskId="DevHome.DevInsights.Hotkey" Enabled="true" DisplayName="ms-resource:DIStartupTaskDisplayName" />
+          <uap5:StartupTask TaskId="DevHome.DevDiagnostics.Hotkey" Enabled="true" DisplayName="ms-resource:DDStartupTaskDisplayName" />
         </uap5:Extension>
-        <uap3:Extension Category="windows.appExecutionAlias" Executable="DevHome.DevInsights.exe" EntryPoint="Windows.FullTrustApplication" uap10:RuntimeBehavior="packagedClassicApp" uap10:TrustLevel="mediumIL">
+        <uap3:Extension Category="windows.appExecutionAlias" Executable="DevHome.DevDiagnostics.exe" EntryPoint="Windows.FullTrustApplication" uap10:RuntimeBehavior="packagedClassicApp" uap10:TrustLevel="mediumIL">
           <uap3:AppExecutionAlias>
-            <desktop:ExecutionAlias Alias="devhome.devinsights.exe" />
+            <desktop:ExecutionAlias Alias="devhome.devdiagnostics.exe" />
           </uap3:AppExecutionAlias>
         </uap3:Extension>
       </Extensions>

src/Package.appxmanifest

@@ -364,19 +364,19 @@
 
       </Extensions>
     </Application>
-    <Application Id="Devhome.DevInsights" Executable="DevHome.DevInsights.exe" EntryPoint="Windows.FullTrustApplication">
-      <uap:VisualElements DisplayName="ms-resource:DIDisplayName" Description="ms-resource:DIAppDescription" BackgroundColor="transparent" Square150x150Logo="Assets\Square150x150Logo.png" Square44x44Logo="Assets\Square44x44Logo.png" AppListEntry="none">
+    <Application Id="Devhome.DevDiagnostics" Executable="DevHome.DevDiagnostics.exe" EntryPoint="Windows.FullTrustApplication">
+      <uap:VisualElements DisplayName="ms-resource:DDDisplayName" Description="ms-resource:DDAppDescription" BackgroundColor="transparent" Square150x150Logo="Assets\Square150x150Logo.png" Square44x44Logo="Assets\Square44x44Logo.png" AppListEntry="none">
         <uap:DefaultTile Wide310x150Logo="Assets\Wide310x150Logo.png" />
         <uap:SplashScreen Image="Assets\SplashScreen.png" />
       </uap:VisualElements>
       <Extensions>
         <!-- Limitations in Microsoft.Extension.Configuration require this to be a key=value pair.-->
         <uap5:Extension Category="windows.startupTask" uap10:Parameters="/startuptask=true">
-          <uap5:StartupTask TaskId="DevHome.DevInsights.Hotkey" Enabled="true" DisplayName="ms-resource:DIStartupTaskDisplayName" />
+          <uap5:StartupTask TaskId="DevHome.DevDiagnostics.Hotkey" Enabled="true" DisplayName="ms-resource:DDStartupTaskDisplayName" />
         </uap5:Extension>
-        <uap3:Extension Category="windows.appExecutionAlias" Executable="DevHome.DevInsights.exe" EntryPoint="Windows.FullTrustApplication" uap10:RuntimeBehavior="packagedClassicApp" uap10:TrustLevel="mediumIL">
+        <uap3:Extension Category="windows.appExecutionAlias" Executable="DevHome.DevDiagnostics.exe" EntryPoint="Windows.FullTrustApplication" uap10:RuntimeBehavior="packagedClassicApp" uap10:TrustLevel="mediumIL">
           <uap3:AppExecutionAlias>
-            <desktop:ExecutionAlias Alias="devhome.devinsights.exe" />
+            <desktop:ExecutionAlias Alias="devhome.devdiagnostics.exe" />
           </uap3:AppExecutionAlias>
         </uap3:Extension>
       </Extensions>

src/Program.cs

@@ -70,7 +70,7 @@ private static async Task<bool> DecideRedirection()
     // Currently DevHome supports one set of command line arguments, most useful when debugging different apps within the Dev Home package.
     //
     // For example:
-    //    --utilitylaunch DevHome.DevInsights.Exe --utilityLaunchArgs "--application problemapp2"
+    //    --utilitylaunch DevHome.DevDiagnostics.Exe --utilityLaunchArgs "--application problemapp2"
     //
     // --utilityLaunch is the name of the utility to launch
     // --utilityLaunchArgs are the arguments to pass to the utility. This is optional, but be sure to include the quotes if you have spaces in the arguments.

src/Properties/launchsettings.json

@@ -8,9 +8,9 @@
     "DevHome (Unpackaged)": {
       "commandName": "Project"
     },
-    "DevInsights (Package)": {
+    "DevDiagnostics (Package)": {
       "commandName": "MsixPackage",
-      "commandLineArgs": "--utilitylaunch DevHome.DevInsights.Exe ",
+      "commandLineArgs": "--utilitylaunch DevHome.DevDiagnostics.Exe ",
       "nativeDebugging": true
     }
   }

tools/DevDiagnostics/DevHome.DevDiagnostics.UnitTest/TestingScenarios/DevDiagnostics.md

@@ -0,0 +1,25 @@
+# Dev Diagnostics Tests
+If your code affects Dev Diagnostics, please manually verify these scenarios.
+
+## Scenarios
+Please make sure to verify all of these scenarios. These apply to both Windows 10 and Windows 11.
+
+### First Run and First Setup Experience
+1. Dev Diagnostics: On Dev/Canary/Preview toggle Dev Diagnostics experimental feature on/off/on again to enable startup task
+1. Dev Diagnostics: Reboot and invoking Dev Diagnostics with Win-F12 should launch it immediately.
+
+### Core Feature (Feature is Enabled and Configured)
+1. Dev Diagnostics: Attach to foreground app - Launch any app and Hit Win-F12, Validate app that is in foreground was selected in Dev Diagnostics
+1. Dev Diagnostics: Close Bar Window, Hit Win-F12. Validate app that is in foreground was selected in Dev Diagnostics.
+1. Dev Diagnostics WinLogs: Remove yourself from Performance Log Users from lsusrmgr.ms, Log out and log back in to Windows
+1. Dev Diagnostics WinLogs: Validate that ETW logs are unchecked by default and checking them triggers a UAC prompt
+1. Dev Diagnostics WinLogs: Accept UAC prompt, Log Out and log back in, ETW logs should be checked by default.
+1. Dev Diagnostics WinLogs: Attach to an application and validate logs are working.
+1. Dev Diagnostics WinLogs: Crash the app/end task from taskmanager and validate logs
+1. Dev Diagnostics WinLogs: ETW logs check box works. Example scenario - attach to notepad and close it.
+1. Dev Diagnostics WinLogs: Debug output check-box works. Example scenario - Attach to DevHome, go to Widgets page and add widgets like CPU and GPU.
+1. .Dev Diagnostics ProcessList Page: Filter text box works both for Dev Diagnostics and process name
+1. Dev Diagnostics ProcessList Page: Click on any process and confirm Dev Diagnostics attaches to that process.
+1. Dev Diagnostics ProcessList Page: After attaching to new process, verify that other pages have relevant info related to newly attached process.
+1. Dev Diagnostics System Process/Admin Process: Attach Dev Diagnostics to Task Manager or other system process, verify that AppDetails and Modules page show "Run As Admin" button
+1. Dev Diagnostics System Process/Admin Process: Clicking on "Run As Admin" button should work.