Fix links on Dev Drive insights (#2803)

* Remove broken link, add new learn more link on package caches * Addressed PR comments * Addressed PR comments
microsoft · May 3, 2024 · 01a22cf · 01a22cf
1 parent fec7bc0
commit 01a22cf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/tools/Customization/DevHome.Customization/Strings/en-us/Resources.resw b/tools/Customization/DevHome.Customization/Strings/en-us/Resources.resw
@@ -242,9 +242,13 @@
     <comment>Optimizer dev drive description when environment variable is not set</comment>
   </data>
   <data name="PackageCachesDescription.Text" xml:space="preserve">
-    <value>A package cache is the global folder location used by an application to store files for installed software. These source files are needed when you want to update, uninstall, or repair the installed software. Visual Studio is one such application that stores a large portion of its data in the Package Cache.</value>
+    <value>A package cache is the global folder location used by an application to store files for installed software. These source files are needed when you want to update, uninstall, or repair the installed software. </value>
     <comment>Package caches description</comment>
   </data>
+  <data name="PackageCachesLearnMoreLink.Text" xml:space="preserve">
+    <value>Learn more</value>
+    <comment>Package caches hyperlink text</comment>
+  </data>
   <data name="SettingsAutoSuggestBox.PlaceholderText" xml:space="preserve">
     <value>Search</value>
     <comment>The placholder text for the settings auto suggest box</comment>

diff --git a/tools/Customization/DevHome.Customization/Views/DevDriveInsightsView.xaml b/tools/Customization/DevHome.Customization/Views/DevDriveInsightsView.xaml
@@ -92,10 +92,9 @@
                                 IsTextSelectionEnabled="True"/>
                     </Grid>
                     <ctControls:SettingsExpander.Items>
-                        <ctControls:SettingsCard Description="{Binding Path=OptimizerDevDriveDescription, Mode=OneWay}">
+                        <ctControls:SettingsCard Padding="60 10 20 15" Description="{Binding Path=OptimizerDevDriveDescription, Mode=OneWay}">
                             <Button x:Name="OptimizerDialogLauncher" Content="{x:Bind MakeTheChangeText, Mode=OneWay}" Command="{Binding OptimizeDevDriveCommand}" CommandParameter="{Binding ElementName=OptimizerDialogLauncher}"/>
-                        </ctControls:SettingsCard>
-                        <ctControls:SettingsCard Header="{Binding Path=CacheToBeMoved, Mode=OneWay}" Foreground="{ThemeResource HyperlinkButtonForeground}"/>
+                        </ctControls:SettingsCard>
                     </ctControls:SettingsExpander.Items>
                 </ctControls:SettingsExpander>
             </DataTemplate>
@@ -152,12 +151,12 @@
                 Style="{StaticResource CardBodyStackPanelTextBlockStyle}"
                 Text="Package Caches"
                 IsTextSelectionEnabled="True"/>
-            <TextBlock
-                Margin="0 10 0 0"
-                Style="{StaticResource CardBodyStackPanelAltTextBlockStyle}"
-                x:Uid ="PackageCachesDescription"
-                IsTextSelectionEnabled="True"
-                TextWrapping="WrapWholeWords"/>
+            <TextBlock Margin="0 10 0 0" Style="{StaticResource CardBodyStackPanelAltTextBlockStyle}" TextWrapping="WrapWholeWords">
+                <Run x:Uid="PackageCachesDescription"/>
+                <Hyperlink NavigateUri="https://go.microsoft.com/fwlink/?linkid=2268089">
+                    <Run x:Uid="PackageCachesLearnMoreLink" />
+                </Hyperlink>
+            </TextBlock>
             <!--- List of DevDriveOptimizersListViewModel objects. -->
             <ListView
                 x:Name="DevDriveOptimizersList"