Update Dart/Flutter adapters (#377)

* Clarify that absent canRestart on frame implies true (#365) Closes #347 * Update Dart/Flutter adapters Dart and Flutter SDKs now ship with their own generic DAP implementations that are usable by clients other than VS Code. --------- Co-authored-by: Mathias Fußenegger <[email protected]> Co-authored-by: Connor Peet <[email protected]>
microsoft · Mar 2, 2023 · 3e0628a · 3e0628a
1 parent 89cfd9a
commit 3e0628a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/_implementors/adapters.md b/_implementors/adapters.md
@@ -20,7 +20,7 @@ Many adapters publish releases tailored for specific editors, such as VS Code, a
 [C/C++/Rust](https://github.com/Marus/cortex-debug)|[@Marus](https://github.com/Marus)|[VS Code](https://marketplace.visualstudio.com/items?itemName=marus25.cortex-debug)
 [C#](https://github.com/OmniSharp/omnisharp-vscode)|[@gregg-miskelly](https://github.com/gregg-miskelly)|[VS Code](https://marketplace.visualstudio.com/items?itemName=ms-vscode.csharp)
 [Cordova Tools](https://github.com/Microsoft/vscode-cordova)|[@MSLaguana](https://github.com/MSLaguana)|[VS Code](https://marketplace.visualstudio.com/items?itemName=vsmobile.cordova-tools)
-[Dart](https://github.com/Dart-Code/Dart-Code)|[@DanTup](https://github.com/DanTup) [@devoncarew](https://github.com/devoncarew)|[VS Code](https://marketplace.visualstudio.com/items?itemName=Dart-Code.dart-code)
+[Dart](https://github.com/dart-lang/sdk)|[@DanTup](https://github.com/DanTup) [@devoncarew](https://github.com/devoncarew)|[DAP Server](https://github.com/dart-lang/sdk/blob/master/pkg/dds/tool/dap/README.md), [VS Code](https://marketplace.visualstudio.com/items?itemName=Dart-Code.dart-code)
 [Debug](https://github.com/WebFreak001/code-debug)|[@WebFreak001](https://github.com/WebFreak001)|[VS Code](https://marketplace.visualstudio.com/items?itemName=webfreak.debug)
 [Debugger for Chrome](https://github.com/microsoft/vscode-chrome-debug)|[@roblourens](https://github.com/roblourens)|[VS Code](https://marketplace.visualstudio.com/items?itemName=msjsdiag.debugger-for-chrome)
 [Debugger for Edge](https://github.com/Microsoft/vscode-edge-debug2)|[@andysterland](https://github.com/andysterland)|[VS Code](https://marketplace.visualstudio.com/items?itemName=msjsdiag.debugger-for-edge)
@@ -39,6 +39,7 @@ Many adapters publish releases tailored for specific editors, such as VS Code, a
 [ESP32 Debugger](https://github.com/espressif/esp-debug-adapter)|[@espressif](https://github.com/espressif)|[DAP Server](https://github.com/espressif/esp-debug-adapter#usage)
 [Firefox Remote Debug](https://github.com/yurydelendik/vscode-ff-debug)|[@yurydelendik](https://github.com/yurydelendik)|[VS Code](https://marketplace.visualstudio.com/items?itemName=yurydelendik.firefox-debug)
 [Flash](https://github.com/vshaxe/flash-debugger)|[@vshaxe](https://github.com/vshaxe/)|[VS Code](https://marketplace.visualstudio.com/items?itemName=vshaxe.haxe-debug)
+[Flutter](https://github.com/flutter/flutter)|[@DanTup](https://github.com/DanTup) [@devoncarew](https://github.com/devoncarew)|[DAP Server](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/debug_adapters/README.md), [VS Code](https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter)
 [Go Delve Debugger](https://github.com/go-delve/delve/tree/master/service/dap)| [@polinasok](https://github.com/polinasok) and [Delve](https://github.com/go-delve)| [DAP Server](https://github.com/go-delve/delve/tree/master/Documentation/api/dap), [VS Code](https://github.com/golang/vscode-go/blob/master/docs/debugging.md)
 [Harbour](https://github.com/APerricone/harbourCodeExtension)|[@APerricone](https://github.com/APerricone)|[VS Code](https://marketplace.visualstudio.com/items?itemName=aperricone.harbour)
 [HashLink](https://github.com/vshaxe/hashlink-debugger)|[@vshaxe](https://github.com/vshaxe/)|[VS Code](https://marketplace.visualstudio.com/items?itemName=HaxeFoundation.haxe-hl)

diff --git a/debugAdapterProtocol.json b/debugAdapterProtocol.json
@@ -3486,7 +3486,7 @@
 				},
 				"canRestart": {
 					"type": "boolean",
-					"description": "Indicates whether this frame can be restarted with the `restart` request. Clients should only use this if the debug adapter supports the `restart` request and the corresponding capability `supportsRestartRequest` is true."
+					"description": "Indicates whether this frame can be restarted with the `restart` request. Clients should only use this if the debug adapter supports the `restart` request and the corresponding capability `supportsRestartRequest` is true. If a debug adapter has this capability, then `canRestart` defaults to `true` if the property is absent."
 				},
 				"instructionPointerReference": {
 					"type": "string",

diff --git a/specification.md b/specification.md
@@ -3797,6 +3797,8 @@ interface StackFrame {
    * Indicates whether this frame can be restarted with the `restart` request.
    * Clients should only use this if the debug adapter supports the `restart`
    * request and the corresponding capability `supportsRestartRequest` is true.
+   * If a debug adapter has this capability, then `canRestart` defaults to
+   * `true` if the property is absent.
    */
   canRestart?: boolean;