Make max q depth a global definition

DPDPU/Common/Include/Protocol.h

@@ -61,6 +61,8 @@
 #define RING_BUFFER_REQUEST_META_DATA_SIZE 128
 #define RING_BUFFER_RESPONSE_META_DATA_SIZE 128
 
+#define DDS_MAX_OUTSTANDING_IO 256
+
 //
 // Check a few parameters at the compile time
 //
@@ -87,5 +89,5 @@ assert_static_protocol(DDS_RESPONSE_RING_BYTES % DDS_CACHE_LINE_SIZE == 0, 5);
 #pragma warning(pop)
 #endif
 
-#define DDS_BACKEND_ADDR "172.16.1.3"
+#define DDS_BACKEND_ADDR "172.16.3.72"
 #define DDS_BACKEND_PORT 4242

DPDPU/Common/Source/Host/DMABuffer.cpp

@@ -133,7 +133,7 @@ DMABuffer::Allocate(
 	// Post receives to allow backend to write responses
 	//
 	//
-	for (int i = 0; i != DDS_FRONTEND_MAX_OUTSTANDING; i++) {
+	for (int i = 0; i != DDS_MAX_OUTSTANDING_IO; i++) {
 		RDMC_PostReceive(QPair, MsgSgl, 1, MSG_CTXT);
 	}
 

DPDPU/StorageEngine/DDSApplication/DDSApplication.cpp

@@ -95,14 +95,14 @@ void BenchmarkIO(
     }
 
     cout << "Benchmarking reads..." << endl;
-    char* readBuffer = new char[PAGE_SIZE * DDS_FRONTEND_MAX_OUTSTANDING];
-    memset(readBuffer, 0, sizeof(char) * PAGE_SIZE * DDS_FRONTEND_MAX_OUTSTANDING);
+    char* readBuffer = new char[PAGE_SIZE * DDS_MAX_OUTSTANDING_IO];
+    memset(readBuffer, 0, sizeof(char) * PAGE_SIZE * DDS_MAX_OUTSTANDING_IO);
     completedIOs = 0;
     profiler.Start();
     for (size_t i = 0; i != totalIOs; i++) {
         result = Store.ReadFile(
             FileId,
-            &readBuffer[(i % DDS_FRONTEND_MAX_OUTSTANDING) * PAGE_SIZE],
+            &readBuffer[(i % DDS_MAX_OUTSTANDING_IO) * PAGE_SIZE],
             PAGE_SIZE,
             &bytesServiced,
             DummyCallback,
@@ -240,8 +240,8 @@ BenchmarkIOWithPolling(
     }
 
     cout << "Benchmarking reads..." << endl;
-    char* readBuffer = new char[PAGE_SIZE * DDS_FRONTEND_MAX_OUTSTANDING];
-    memset(readBuffer, 0, sizeof(char) * PAGE_SIZE * DDS_FRONTEND_MAX_OUTSTANDING);
+    char* readBuffer = new char[PAGE_SIZE * DDS_MAX_OUTSTANDING_IO];
+    memset(readBuffer, 0, sizeof(char) * PAGE_SIZE * DDS_MAX_OUTSTANDING_IO);
 
     pollWorker = new thread(
         [&Store, FileId, totalIOs]
@@ -252,7 +252,7 @@ BenchmarkIOWithPolling(
     for (size_t i = 0; i != totalIOs; i++) {
         result = Store.ReadFile(
             FileId,
-            &readBuffer[(i % DDS_FRONTEND_MAX_OUTSTANDING) * PAGE_SIZE],
+            &readBuffer[(i % DDS_MAX_OUTSTANDING_IO) * PAGE_SIZE],
             PAGE_SIZE,
             &bytesServiced,
             NULL,

DPDPU/StorageEngine/DDSFrontEnd/DDSFrontEnd.cpp

@@ -15,7 +15,7 @@ namespace DDS_FrontEnd {
 //
 //
 PollT::PollT() {
-    for (size_t i = 0; i != DDS_FRONTEND_MAX_OUTSTANDING; i++) {
+    for (size_t i = 0; i != DDS_MAX_OUTSTANDING_IO; i++) {
         OutstandingRequests[i] = nullptr;
     }
 #if BACKEND_TYPE == BACKEND_TYPE_DPU
@@ -133,7 +133,7 @@ DDSFrontEnd::~DDSFrontEnd() {
 #if BACKEND_TYPE == BACKEND_TYPE_DPU
             AllPolls[p]->DestroyDMABuffer();
 #endif
-            for (size_t i = 0; i != DDS_FRONTEND_MAX_OUTSTANDING; i++) {
+            for (size_t i = 0; i != DDS_MAX_OUTSTANDING_IO; i++) {
                 delete AllPolls[p]->OutstandingRequests[i];
             }
 
@@ -185,7 +185,7 @@ DDSFrontEnd::Initialize() {
     //
     //
     PollT* poll = new PollT();
-    for (size_t i = 0; i != DDS_FRONTEND_MAX_OUTSTANDING; i++) {
+    for (size_t i = 0; i != DDS_MAX_OUTSTANDING_IO; i++) {
         poll->OutstandingRequests[i] = new FileIOT();
         if (!poll->OutstandingRequests[i]) {
             fprintf(stderr, "%s [error]: Failed to allocate a file I/O object\n", __func__);
@@ -573,7 +573,7 @@ DDSFrontEnd::ReadFile(
 
     PollT* poll = AllPolls[AllFiles[FileId]->PollId];
     size_t mySlot = poll->NextRequestSlot.fetch_add(1, std::memory_order_relaxed);
-    mySlot %= DDS_FRONTEND_MAX_OUTSTANDING;
+    mySlot %= DDS_MAX_OUTSTANDING_IO;
     FileIOT* pIO = poll->OutstandingRequests[mySlot];
 
     //
@@ -643,7 +643,7 @@ DDSFrontEnd::ReadFile(
     PollIdT pollId = AllFiles[FileId]->PollId;
     PollT* poll = AllPolls[pollId];
     size_t mySlot = poll->NextRequestSlot.fetch_add(1, std::memory_order_relaxed);
-    mySlot %= DDS_FRONTEND_MAX_OUTSTANDING;
+    mySlot %= DDS_MAX_OUTSTANDING_IO;
     FileIOT* pIO = poll->OutstandingRequests[mySlot];
 
     bool expectedAvail = true;
@@ -729,7 +729,7 @@ DDSFrontEnd::ReadFileScatter(
 
     PollT* poll = AllPolls[AllFiles[FileId]->PollId];
     size_t mySlot = poll->NextRequestSlot.fetch_add(1, std::memory_order_relaxed);
-    mySlot %= DDS_FRONTEND_MAX_OUTSTANDING;
+    mySlot %= DDS_MAX_OUTSTANDING_IO;
     FileIOT* pIO = poll->OutstandingRequests[mySlot];
 
     //
@@ -799,7 +799,7 @@ DDSFrontEnd::ReadFileScatter(
     PollIdT pollId = AllFiles[FileId]->PollId;
     PollT* poll = AllPolls[pollId];
     size_t mySlot = poll->NextRequestSlot.fetch_add(1, std::memory_order_relaxed);
-    mySlot %= DDS_FRONTEND_MAX_OUTSTANDING;
+    mySlot %= DDS_MAX_OUTSTANDING_IO;
     FileIOT* pIO = poll->OutstandingRequests[mySlot];
 
     bool expectedAvail = true;
@@ -886,7 +886,7 @@ DDSFrontEnd::WriteFile(
 
     PollT* poll = AllPolls[AllFiles[FileId]->PollId];
     size_t mySlot = poll->NextRequestSlot.fetch_add(1, std::memory_order_relaxed);
-    mySlot %= DDS_FRONTEND_MAX_OUTSTANDING;
+    mySlot %= DDS_MAX_OUTSTANDING_IO;
     FileIOT* pIO = poll->OutstandingRequests[mySlot];
 
     //
@@ -957,7 +957,7 @@ DDSFrontEnd::WriteFile(
     PollIdT pollId = AllFiles[FileId]->PollId;
     PollT* poll = AllPolls[pollId];
     size_t mySlot = poll->NextRequestSlot.fetch_add(1, std::memory_order_relaxed);
-    mySlot %= DDS_FRONTEND_MAX_OUTSTANDING;
+    mySlot %= DDS_MAX_OUTSTANDING_IO;
     FileIOT* pIO = poll->OutstandingRequests[mySlot];
 
     bool expectedAvail = true;
@@ -1043,7 +1043,7 @@ DDSFrontEnd::WriteFileGather(
 
     PollT* poll = AllPolls[AllFiles[FileId]->PollId];
     size_t mySlot = poll->NextRequestSlot.fetch_add(1, std::memory_order_relaxed);
-    mySlot %= DDS_FRONTEND_MAX_OUTSTANDING;
+    mySlot %= DDS_MAX_OUTSTANDING_IO;
     FileIOT* pIO = poll->OutstandingRequests[mySlot];
 
     //
@@ -1120,7 +1120,7 @@ DDSFrontEnd::WriteFileGather(
     PollIdT pollId = AllFiles[FileId]->PollId;
     PollT* poll = AllPolls[pollId];
     size_t mySlot = poll->NextRequestSlot.fetch_add(1, std::memory_order_relaxed);
-    mySlot %= DDS_FRONTEND_MAX_OUTSTANDING;
+    mySlot %= DDS_MAX_OUTSTANDING_IO;
     FileIOT* pIO = poll->OutstandingRequests[mySlot];
 
     bool expectedAvail = true;
@@ -1445,7 +1445,7 @@ DDSFrontEnd::PollCreate(
     }
 
     PollT* poll = new PollT();
-    for (size_t i = 0; i != DDS_FRONTEND_MAX_OUTSTANDING; i++) {
+    for (size_t i = 0; i != DDS_MAX_OUTSTANDING_IO; i++) {
         poll->OutstandingRequests[i] = new FileIOT();
     }
     poll->NextRequestSlot = 0;
@@ -1473,7 +1473,7 @@ DDSFrontEnd::PollDelete(
         return DDS_ERROR_CODE_INVALID_POLL_DELETION;
     }
 
-    for (size_t i = 0; i != DDS_FRONTEND_MAX_OUTSTANDING; i++) {
+    for (size_t i = 0; i != DDS_MAX_OUTSTANDING_IO; i++) {
         delete poll->OutstandingRequests[i];
     }
     delete poll;
@@ -1528,7 +1528,7 @@ DDSFrontEnd::PollWait(
     size_t sleepTimeInUs = 1;
 
     while (true) {
-        for (size_t i = 0; i != DDS_FRONTEND_MAX_OUTSTANDING; i++) {
+        for (size_t i = 0; i != DDS_MAX_OUTSTANDING_IO; i++) {
             FileIOT* io = poll->OutstandingRequests[i];
 
             bool expectedCompletion = true;

DPDPU/StorageEngine/DDSFrontEnd/DDSFrontEndConfig.h

@@ -1,7 +1,5 @@
 #pragma once
 
-#define DDS_FRONTEND_MAX_OUTSTANDING 128
-
 #define BACKEND_TYPE_LOCAL_MEMORY 0
 #define BACKEND_TYPE_DPU 1
 #define BACKEND_TYPE BACKEND_TYPE_DPU

DPDPU/StorageEngine/DDSFrontEnd/DDSFrontEndTypes.h

@@ -43,7 +43,7 @@ typedef struct FileIOT {
 //
 //
 typedef struct PollT {
-    FileIOT* OutstandingRequests[DDS_FRONTEND_MAX_OUTSTANDING];
+    FileIOT* OutstandingRequests[DDS_MAX_OUTSTANDING_IO];
     Atomic<size_t> NextRequestSlot;
 #if BACKEND_TYPE == BACKEND_TYPE_DPU
     DMABuffer* MsgBuffer;