Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppwinrt code base should have clang-tidy formatting enforced automatically #1459

Open
dmachaj opened this issue Nov 24, 2024 · 2 comments · May be fixed by #1461
Open

cppwinrt code base should have clang-tidy formatting enforced automatically #1459

dmachaj opened this issue Nov 24, 2024 · 2 comments · May be fixed by #1461

Comments

@dmachaj
Copy link
Contributor

dmachaj commented Nov 24, 2024

Version

No response

Summary

There is nothing enforcing coding style consistency so there is variance that creeps in over time (e.g. some files have tabs, some have spaces). It would be nice to use automation to enforce at least a bare minimum of consistency so that there is one less thing to think about.

Reproducible example



Expected behavior


No response


Actual behavior


No response


Additional comments


No response

      		
    

      
  





        

            


            

              
            

        

      


      
    








      

    



      

  
          

  

    
  


  

      

    @dmachaj
dmachaj



    mentioned this issue
    
      Nov 24, 2024
    





  


  

      
   Merged

  







  









      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

      

      
            github-actions
  bot

      

      

      commented


        Dec 5, 2024


      
    


  





      


        


  
    

      
          
This issue is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            


    


    

    

      
    

    


      

          @dmachaj
dmachaj




        changed the title
cppwinrt code base should have .editorconfig and/or clang-tidy formatting enforced automatically

cppwinrt code base should have clang-tidy formatting enforced automatically


      Dec 6, 2024

    

  



  

  

    
  


  

      

    @dmachaj
dmachaj



    linked a pull request
    
      Dec 6, 2024
    

    that will
    close
    this issue





  


  

      
   Open

  







  









      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
This issue is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            


    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  



      

    

  
      

  

    

      1 participant
    

    

        
          @dmachaj