-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes on #866 which broke building for iOS and Mac #888
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
09714d9
Various fixes on #866 which broke building for iOS and Mac
b0927b9
Remove trailing semicolon from namespace since flags error when build…
d2b8032
Ubuntu builds needs to factor in unused arguments/variables
893c101
Remove trailing spaces from empty lines
8d80a36
Merge branch 'master' into issue_887
BillyONeal ba20325
Remove duplicate bind_impls.
BillyONeal 790e620
Fix some merge fallout with master.
BillyONeal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What issue did this initializer cause? And will this empty initializer ensure that all members of the z_stream struct are initialized to zero? I think it might, but I'm not confident enough in my reading of the spec on that point to swear to it.
If not, then we'll need a memset to zero in the zlib_compressor_base (and zlib_decompressor_base) constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the errors are listed in #887. This one in particular generated
I was surprised by this one as well.
https://stackoverflow.com/questions/1538943/why-is-the-compiler-throwing-this-warning-missing-initializer-isnt-the-stru
Seems like it is, as the one poster in that SO put it, "GCC is just being overly paranoid". That posting is old, but yet it seems like the issue still exists. It looks like there have been requests to change it as well.
Let me know how you want this handled, in the meantime I'll make the other changes you listed above later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and sorry for not directly replying. They should be the same.
https://stackoverflow.com/questions/41006259/brace-initialization-difference-betweein-and-0-in-c
https://en.cppreference.com/w/cpp/language/value_initialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the two items you mentioned. I'm not going to mark this as resolved ... if you feel this is suitable, then you can mark it as such. Or let me know what you'd like to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links are helpful. I don't seem to have a button available to mark this as resolved; possibly just ignorance on my part?
I'd like @BillyONeal to confirm, though, anyway -- and he'll have to review this, regardless, as I don't have permission to merge it.