Fixed proxy issue when using WPAD on Windows 8.1+ #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
When this will be merged to master? I've encountered this issue as well, and would prefer not to have to run in Windows 7 compatibility mode. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If IE was set to use Web-Proxy Auto-Dicovery (WPAD) on Windows 8.1 or newer, a request would fail with "Settings proxy options: 12011: The option value cannot be set" when trying to set the proxy for the request.
The new WINHTTP_ACCESS_TYPE_AUTOMATIC_PROXY doesn't allow manually specifying the proxy by using WinHttpSetOption.
Please note that the error is only triggered if the executable has a manifest specifying support for Windows 8.1+. Otherwise the calling process will run in Windows Vista compatibility mode, and not trigger the error.