Add CPPREST_EXCLUDE_WEBSOCKETS option to CMake #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Release/CMakeLists.txt Release/src/CMakeLists.txt Release/tests/common/TestRunner/CMakeLists.txt
|
Hi @ras0219, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| message("-- websocketpp not found, using the embedded version") | ||
| endif(WEBSOCKETPP_CONFIG AND WEBSOCKETPP_CONFIG_VERSION) | ||
| else() | ||
| set(Casablanca_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/include) |
There was a problem hiding this comment.
why are we setting this again in the else() part?
kavyako
added a commit
that referenced
this pull request
Dec 9, 2015
Add CPPREST_EXCLUDE_WEBSOCKETS option to CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the cmake option "CPPREST_EXCLUDE_WEBSOCKETS" which (on Windows) will remove all OpenSSL and Boost dependencies.
Ex:
Additionally, this enables non-VS generators on Windows (at the cost of disabling PCH).