iOS build clang suppression list #23
Conversation
…ression list. It solves build problems on iOS.
|
Hi @rinopazzo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| @@ -134,7 +134,7 @@ elseif((CMAKE_CXX_COMPILER_ID MATCHES "Clang") OR IOS) | |||
| message("-- Setting clang options") | |||
|
|
|||
| set(WARNINGS "-Wall -Wextra -Wcast-qual -Wconversion -Wformat=2 -Winit-self -Winvalid-pch -Wmissing-format-attribute -Wmissing-include-dirs -Wpacked -Wredundant-decls") | |||
| set(OSX_SUPPRESSIONS "-Wno-overloaded-virtual -Wno-sign-conversion -Wno-deprecated -Wno-unknown-pragmas -Wno-reorder -Wno-char-subscripts -Wno-switch -Wno-unused-parameter -Wno-unused-variable -Wno-deprecated -Wno-unused-value -Wno-unknown-warning-option -Wno-return-type-c-linkage -Wno-unused-function -Wno-sign-compare -Wno-shorten-64-to-32 -Wno-reorder") | |||
| set(OSX_SUPPRESSIONS "-Wno-overloaded-virtual -Wno-sign-conversion -Wno-deprecated -Wno-unknown-pragmas -Wno-reorder -Wno-char-subscripts -Wno-switch -Wno-unused-parameter -Wno-unused-variable -Wno-deprecated -Wno-unused-value -Wno-unknown-warning-option -Wno-return-type-c-linkage -Wno-unused-function -Wno-sign-compare -Wno-shorten-64-to-32 -Wno-reorder -Wno-error -Wno-unused-local-typedefs") | |||
There was a problem hiding this comment.
Why do we need the -Wno-error? Do we have any other warning causing build failures? It is better to have the warnings cause build failure so we can address the failures appropriately (either by fixing the code or by suppressing the warning consciously).
There was a problem hiding this comment.
Also is it -Wunused-local-typedef or -Wunused-local-typedefs ?
|
It is -Wunused-local-typedefs because -Wunused-local-typedef not works on iOS. |
|
-Wno-error is not needed, it is a my mistake. |
|
Removed the -Wno-error and merged the changes into development branch. Thank you for fixing the build break. |
Added "-Wno-error" and "-Wno-unused-local-typedefs" to the clang suppression list into Release/CMakeLists.xtx. It solves build problems on iOS.
Without this options the build process on iOS fails.