Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake minimum required version should actually be 3.1 #633

Closed
jneuff opened this issue Dec 19, 2017 · 1 comment
Closed

CMake minimum required version should actually be 3.1 #633

jneuff opened this issue Dec 19, 2017 · 1 comment

Comments

@jneuff
Copy link

jneuff commented Dec 19, 2017

Release/CMakeLists.txt says cmake_minimum_required(VERSION 3.0).
But Release/src/CMakeLists.txt makes use of the target_sources command which is only available
in CMake 3.1 and above.
@wtfrank
Copy link

wtfrank commented Feb 13, 2018

I also experienced this issue, with cpprest 2.10.1.

vadz added a commit to vadz/cpprestsdk that referenced this issue May 5, 2018
@vadz
Require at least CMake 3.1 due to use of target_sources
536bb6f 
target_sources() is only available since this version and this avoids

CMake Error at src/CMakeLists.txt:92 (target_sources):
  Unknown CMake command "target_sources".

when using CMake 3.0, for example.

Closes microsoft#633.
@vadz vadz mentioned this issue May 5, 2018
Merged
ras0219-msft pushed a commit that referenced this issue May 5, 2018
@vadz @ras0219-msft
Require at least CMake 3.1 due to use of target_sources (#752)
175d0ac 
target_sources() is only available since this version and this avoids

CMake Error at src/CMakeLists.txt:92 (target_sources):
  Unknown CMake command "target_sources".

when using CMake 3.0, for example.

Closes #633.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jneuff @wtfrank