Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse variable names in telemetry verfication #89

Merged
merged 4 commits into from
Sep 20, 2019

Conversation

rhurey
Copy link
Member

@rhurey rhurey commented Sep 19, 2019

No description provided.

Copy link
Contributor

@BrianMouncer BrianMouncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Contributor

@BrianMouncer BrianMouncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rhurey rhurey merged commit 6c30e18 into master Sep 20, 2019
BrianMouncer pushed a commit that referenced this pull request Sep 20, 2019
* Don't reuse variable names in telemetry verfication

* And now hypothesis

* When speech.end is detected, only shrink replay buffer for continuous recognition. Fix other bugs in telemetry verification code.

* Fix whitespace
@rhurey rhurey deleted the rhurey/telemetry.test.fix branch December 2, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants