Fix Division by Zero Error in audioOffsetMs Calculation

[motamed]

This pull request addresses a potential division by zero error in the calculation of audioOffsetMs within the ServiceRecognizerBase.ts file. The fix ensures that if this.privAverageBytesPerMs is zero, audioOffsetMs is set to zero instead of attempting to perform the division.

UAT Tracker ID : 304110

Changes Made:

• Updated the calculation of audioOffsetMs to include a conditional check that sets audioOffsetMs to zero if this.privAverageBytesPerMs is zero.

Code Changes:

const audioOffsetMs: number = this.privAverageBytesPerMs != 0 ? bytesSent / this.privAverageBytesPerMs : 0;

Tested Scenario:

• The Current code throw an error when used in PowerApps PCF control for speech recognition .

ConversationTranscriptionCanceledEventArgs {privSessionId: '653442B08C524EA4ADDB66A19C992187', privOffset: undefined, privReason: 0, privErrorDetails: 'Could not deserialize speech context. websocket error code: 1007', privErrorCode: 2}

[motamed]

@hkamel

[motamed]

any updates on this ?

[rhurey]

The linter error'd out...
D:\a_work\1\s\src\common.speech\ServiceRecognizerBase.ts
669:66 error Expected '!==' and instead saw '!='

(Looking at why the pipeline results aren't showing up)

[motamed]

The linter error'd out... D:\a_work\1\s\src\common.speech\ServiceRecognizerBase.ts 669:66 error Expected '!==' and instead saw '!='

(Looking at why the pipeline results aren't showing up)

I updated the code accordingly

[rhurey]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rhurey]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rhurey]

Pipeline is failing because of ADO config. Manual build 149400 passed

[motamed]

Quick question
how does the release cycle work? and when is the next release?

[rhurey]

We generally release every couple months. The current release (1.41) should go live in the next day.