v2 translation hypothesis, conditionally import audioWorkerUrl method using import.meta #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
glharper
commented
Sep 22, 2023
•
glharper
commented
- add handling for v2 translation hypothesis messages
- React Native customers can't use import.meta, and customers not using browser microphone functionality don't need to deal with import.meta related errors. This conditionally loads the import.meta code if needed, not at SDK library load time.
|
With this change, the jest.mock additions to our tests may not be needed anymore. Will update PR if that turns out to be the case. |
glharper
changed the title
dargilco
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.