Added 'LocaleName' in VoiceInfo Class #679
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added LocaleName variable in VoiceInfo Class
glharper
requested changes
May 18, 2023
Updated SynthesisVoicesResult class as per new VoiceInfo constructor
|
@microsoft-github-policy-service agree |
glharper
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds support for the 'LocaleName' property in the Azure Cognitive Speech SDK, aligning it with the functionality provided by the web API.
Motivation:
The web API in the Azure Cognitive Speech service at
/cognitiveservices/voices/listreturns a value for 'LocaleName', which indicates the locale or language of the speech input or output. However, this property was missing in the SDK's class variable, causing a mismatch in functionality between the web API and the SDK.Reference Link