-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fmegen/supporting from endpoint with token #36
Conversation
* Note: Please use your LanguageUnderstanding subscription key in case you want to use the Intent recognizer. | ||
* Note: The query parameters specified in the endpoint URL are not changed, even if they are set by any other APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this tested? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, updated the docs for now. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked. #Closed
console.info("Skipping test."); | ||
done(); | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this added test is not running in Azure DevOps? #WontFix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i hope it is part of the end-2-end testing since it takes >10minutes #WontFix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahilleb-msft is there a way to specify this in the pullrequest? #WontFix
// make a connection to the standard speech endpoint. | ||
const endpointString: string = "wss://" + Settings.SpeechRegion + ".stt.speech.microsoft.com"; | ||
|
||
const s: sdk.SpeechConfig = sdk.SpeechConfig.fromEndpoint(new URL(endpointString), Settings.SpeechRegion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gets the endpoint and the region? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// make a connection to the standard speech endpoint. | ||
const endpointString: string = "wss://" + Settings.SpeechRegion + ".stt.speech.microsoft.com"; | ||
|
||
const s: sdk.SpeechConfig = sdk.SpeechConfig.fromEndpoint(new URL(endpointString), Settings.SpeechRegion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Wolfgang pointed out, region seems be wrong? Did the test pass? #Closed
@@ -208,3 +208,179 @@ test("AuthToken refresh works correctly", (done: jest.DoneCallback) => { | |||
}); | |||
}); | |||
}, 1000 * 60 * 25); // 25 minutes. | |||
|
|||
test("AuthToken refresh works even with fromEndpoint configurations", (done: jest.DoneCallback) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it test emty subscription key with fromEndpoint? #Closed
No description provided.