Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net - Fix maintenance-middleware DI #815

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

crickman
Copy link
Contributor

Motivation and Context

Removed required DI as part of #791.

Description

Restore expected contact with empty action array.

Contribution Checklist

@crickman crickman added bug Something isn't working webapi Pull requests that update .net code .NET Pull requests that update .net code labels Feb 21, 2024
@crickman crickman self-assigned this Feb 21, 2024
@crickman crickman added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit a0ccb68 Feb 21, 2024
6 of 7 checks passed
@crickman crickman deleted the fix_maintenancemiddleware branch February 21, 2024 17:32
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Removed required DI as part of
microsoft#791.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Restore expected contact with empty action array.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working .NET Pull requests that update .net code webapi Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants