Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fixes #569

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Workflow fixes #569

merged 2 commits into from
Nov 6, 2023

Conversation

slamb2k
Copy link
Contributor

@slamb2k slamb2k commented Nov 4, 2023

Motivation and Context

  • The deployment workflows have a id-token permission at job level which overwrites the top-level. Not a problem if the repo is public but breaks it if you change to private as checkout can't find the repo.
  • The "stable" environment deployment needs to depend on the earlier builds for artifact names. Without them it, the "stable" deployment fails

Description

  • Moving id-token up ensures both permissions apply.
  • Adding builds as "needs" for "stable" ensures dependencies are available for deployment

Contribution Checklist

@github-actions github-actions bot added the github actions Pull requests that update GitHub Actions code label Nov 4, 2023
@crickman crickman requested a review from glahaye November 6, 2023 05:27
@crickman
Copy link
Contributor

crickman commented Nov 6, 2023

Gil, can you verify how this intersects with your efforts?

@slamb2k
Copy link
Contributor Author

slamb2k commented Nov 6, 2023

My apologies, I just realised Gil has already submitted a PR that fixes the "stable" part of the release pipeline. I can close it and resubmit another one containing just the permissions change if you like.

@crickman
Copy link
Contributor

crickman commented Nov 6, 2023

Up to you on how you'd like to manage the change. If Gil's PR completes, just merging to current might be an option also...your call.

@glahaye glahaye added this pull request to the merge queue Nov 6, 2023
Merged via the queue into microsoft:main with commit 68d6e0a Nov 6, 2023
5 checks passed
@glahaye
Copy link
Collaborator

glahaye commented Nov 6, 2023

@slamb2k I just took your PR as it is a superset of mine.

Thanks for your changes!

teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?  
  2. What problem does it solve?
  3. What scenario does it contribute to? 
  4. If it fixes an open issue, please link to the issue here.
-->

- The deployment workflows have a id-token permission at job level which
overwrites the top-level. Not a problem if the repo is public but breaks
it if you change to private as checkout can't find the repo.
- The "stable" environment deployment needs to depend on the earlier
builds for artifact names. Without them it, the "stable" deployment
fails

### Description

- Moving id-token up ensures both permissions apply.
- Adding builds as "needs" for "stable" ensures dependencies are
available for deployment

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Pull requests that update GitHub Actions code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants