-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow fixes #569
Workflow fixes #569
Conversation
Gil, can you verify how this intersects with your efforts? |
My apologies, I just realised Gil has already submitted a PR that fixes the "stable" part of the release pipeline. I can close it and resubmit another one containing just the permissions change if you like. |
Up to you on how you'd like to manage the change. If Gil's PR completes, just merging to current might be an option also...your call. |
@slamb2k I just took your PR as it is a superset of mine. Thanks for your changes! |
### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> - The deployment workflows have a id-token permission at job level which overwrites the top-level. Not a problem if the repo is public but breaks it if you change to private as checkout can't find the repo. - The "stable" environment deployment needs to depend on the earlier builds for artifact names. Without them it, the "stable" deployment fails ### Description - Moving id-token up ensures both permissions apply. - Adding builds as "needs" for "stable" ensures dependencies are available for deployment ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Motivation and Context
Description
Contribution Checklist