Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global document retrieval and citations #457

Merged

Conversation

TaoChenOSU
Copy link
Collaborator

Motivation and Context

  1. Issue reported by the community: Documents uploaded with global scope not searched by CoPilot memory #421
  2. Citation was accidentally removed by a previous PR.

Description

  1. Fix the issue.
  2. Add back citations.

Contribution Checklist

@TaoChenOSU TaoChenOSU added the bug Something isn't working label Oct 4, 2023
@TaoChenOSU TaoChenOSU self-assigned this Oct 4, 2023
@github-actions github-actions bot added the webapi Pull requests that update .net code label Oct 4, 2023
teresaqhoang
teresaqhoang previously approved these changes Oct 4, 2023
crickman
crickman previously approved these changes Oct 4, 2023
@TaoChenOSU TaoChenOSU dismissed stale reviews from crickman and teresaqhoang via d0b9b99 October 4, 2023 20:41
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Oct 4, 2023
Merged via the queue into microsoft:main with commit 2241167 Oct 4, 2023
7 checks passed
@TaoChenOSU TaoChenOSU deleted the taochen/fix-global-document-retrieval branch October 4, 2023 21:01
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
1. Issue reported by the community:
microsoft#421
2. Citation was accidentally removed by a previous PR.

### Description
1. Fix the issue.
2. Add back citations.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working webapi Pull requests that update .net code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants