Using semantic memory type enum instead of string in API contract. #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glahaye
reviewed
Sep 27, 2023
glahaye
reviewed
Sep 27, 2023
added 4 commits
September 27, 2023 12:24
…difference between the memoryType and the memoryName.
glahaye
approved these changes
Sep 27, 2023
dehoward
approved these changes
Sep 27, 2023
TaoChenOSU
approved these changes
Sep 27, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
…icrosoft#410) ### Motivation and Context Currently the memory retrieval API requires the name of the memory as input, however, the memoryName is something that's configured in the backend and is not known by external clients. This PR refactors things to use a memoryType based on a stable enum as the public interface to the API which allows the memoryName to remain a configuration detail of the backend. --> See issue microsoft#388 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Ben Thomas <[email protected]>
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
…icrosoft#410) ### Motivation and Context Currently the memory retrieval API requires the name of the memory as input, however, the memoryName is something that's configured in the backend and is not known by external clients. This PR refactors things to use a memoryType based on a stable enum as the public interface to the API which allows the memoryName to remain a configuration detail of the backend. --> See issue microsoft#388 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Ben Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently the memory retrieval API requires the name of the memory as input, however, the memoryName is something that's configured in the backend and is not known by external clients. This PR refactors things to use a memoryType based on a stable enum as the public interface to the API which allows the memoryName to remain a configuration detail of the backend.
-->
See issue #388
Description
Contribution Checklist