Adding option for plugin timeout + using proper userId for guest accounts #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
webapp
teresaqhoang
added
bug
github-actions
bot
added
webapp
glahaye
approved these changes
Sep 7, 2023
alliscode
approved these changes
Sep 7, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
…unts (microsoft#314) ### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Two small changes in this PR: 1. Using `${account.localAccountId}.${account.tenantId}` over account.homeAccountId to match how UserId is constructed for chat messages in webapi. 2. Adds another option in appsettings to allow users to set a timeout limit for plugin calls. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. How userId is constructed in webapi:  - `${account.localAccountId}.${account.tenantId}` is more accurate for guest accounts, and it is not equivalent to the homeAccountid (which = `{userIdInHomeTenant}.{HomeTenantId}` for guest accounts). 2. Default HttpClient.Timeout is 100 seconds; customer request to allow this to be configurable to accomodate plugins that take a long time. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
…unts (microsoft#314) ### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Two small changes in this PR: 1. Using `${account.localAccountId}.${account.tenantId}` over account.homeAccountId to match how UserId is constructed for chat messages in webapi. 2. Adds another option in appsettings to allow users to set a timeout limit for plugin calls. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. How userId is constructed in webapi:  - `${account.localAccountId}.${account.tenantId}` is more accurate for guest accounts, and it is not equivalent to the homeAccountid (which = `{userIdInHomeTenant}.{HomeTenantId}` for guest accounts). 2. Default HttpClient.Timeout is 100 seconds; customer request to allow this to be configurable to accomodate plugins that take a long time. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Two small changes in this PR:
${account.localAccountId}.${account.tenantId}over account.homeAccountId to match how UserId is constructed for chat messages in webapi.Description
${account.localAccountId}.${account.tenantId}is more accurate for guest accounts, and it is not equivalent to the homeAccountid (which ={userIdInHomeTenant}.{HomeTenantId}for guest accounts).Contribution Checklist