🚀 Adding new app state to handle user info #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to set user info on login
github-actions
bot
added
webapp
glahaye
previously approved these changes
Aug 9, 2023
TaoChenOSU
reviewed
Aug 10, 2023
TaoChenOSU
previously approved these changes
Aug 10, 2023
dehoward
previously approved these changes
Aug 10, 2023
teresaqhoang
dismissed stale reviews from dehoward, TaoChenOSU, and glahaye
via
478bb35
TaoChenOSU
approved these changes
Aug 11, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Added new app state for setting user info, refactored app views, and added shared styles for informative views. This is a fix for a bug where the webapp would get stuck on the Loading Chats page. Something with SSO caused this. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - The App component now transitions to a SettingUserInfo state after successfully discovering the backend, and then to the LoadingChats state after successfully setting the active user info. - The user info status text in the App component has been updated to display a default message while fetching user information, and an error component has been added to display an error message at view level. - A new useSharedClasses hook has been added to provide a set of shared styles for informative views. - The BackendProbe component has also been updated to use the shared informativeView class. - Added tesseract data files to gitignore ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations ~~- [ ] All unit tests pass, and I have added new tests where possible~~ - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Added new app state for setting user info, refactored app views, and added shared styles for informative views.
This is a fix for a bug where the webapp would get stuck on the Loading Chats page. Something with SSO caused this.
Description
Contribution Checklist
- [ ] All unit tests pass, and I have added new tests where possible