Remove GDEF code from the feature files #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets ufo2ft build the GDEF automatically from what is in the sources. Helpful since it means we don't have to worry about updating it constantly.
|
Neat! No downsides? |
DHowett
changed the title
|
Not that I saw. |
|
Actually the GDEF definitions can also be removed from the sources/*.ufo/features.fea files. |
|
Those are autogenerated by glyphs2ufo and we override them as part of the build process. So they don't need to be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This lets ufo2ft build the GDEF automatically from what is in the sources. Helpful since it means we don't have to worry about updating it constantly.
PR Checklist
Before (if applicable) and After Images of the Character(s)
Resolves diacritic positioning on glyphs previously not included in GDEF
Validation Steps Performed
Checked in FontGoggles. Verified things are working correctly.