Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split the existing profiles into light/verbose and add a verbose mode for bthport #11

Merged
merged 3 commits into from
May 24, 2018

Conversation

arvindaiyar
Copy link
Contributor

This splits the existing Bluetooth profile into 2 modes - a Light mode and a Verbose mode. The Light mode is whatever was there before and will be used in Repro mode etc. The new Verbose mode will allow for changing the verbosity of existing providers - I just added bthport for now.

I tested both profiles and verified that bthport logs are collected at the correct verbosity in each

@erikpe-msft erikpe-msft self-requested a review May 24, 2018 20:04
@erikpe-msft
Copy link
Contributor

erikpe-msft commented May 24, 2018

� � � � �<�E�v�e�n�t�P�r�o�v�i�d�e�r� �I�d�=�"�M�i�c�r�o�s�o�f�t�.�W�i�n�d�o�w�s�.�B�l�u�e�t�o�o�t�h�.�W�P�P�.�B�t�h�P�o�r�t�.�V�e�r�b�o�s�e�"� �N�a�m�e�=�"�d�8�8�a�c�e�0�7�-�c�a�c�0�-�1�1�d�8�-�a�4�c�6�-�0�0�0�d�5�6�0�b�c�b�a�5�"� �L�e�v�e�l�=�"�7�"� �N�o�n�P�a�g�e�d�M�e�m�o�r�y�=�"�t�r�u�e�"�>�

Thoughts about keeping the verbose versions of these providers next to the light versions? I'm torn on whether it's more valuable to see all of the Verbose versions grouped together, or whether it's more valuable to see all of the levels of the same provider grouped together. #Resolved


Refers to: bluetooth/tracing/BluetoothStack.wprp:1135 in 874af02. [](commit_id = 874af02, deletion_comment = False)

@drache42
Copy link
Contributor

Keep light and verbose provides next to each other. Then it's easier to see if a provider already has 2 versions

@arvindaiyar
Copy link
Contributor Author

Moved both the providers next to each other.

@erikpe-msft
Copy link
Contributor

erikpe-msft commented May 24, 2018

� � � � � � �<�C�o�l�l�e�c�t�o�r�s�>�

Taking requests for other verbose level providers? I could see the following being useful:

Microsoft.Windows.Bluetooth.ForkbeardCore
Microsoft.Windows.Bluetooth.ForkbeardPolicy
Microsoft.Windows.Bluetooth.Profiles.Dis
Microsoft.Windows.Bluetooth.Profiles.Gap
Microsoft.Windows.Bluetooth.Profiles.Gatt
Microsoft.Windows.Bluetooth.Protocols.Att
Microsoft.Windows.Bluetooth.WPP.bthusb #WontFix


Refers to: bluetooth/tracing/BluetoothStack.wprp:1405 in 874af02. [](commit_id = 874af02, deletion_comment = False)

@erikpe-msft
Copy link
Contributor

� � � � � � �<�C�o�l�l�e�c�t�o�r�s�>�

In terms of stuff that we're going to test at UPF, at least.


In reply to: 391869591 [](ancestors = 391869591)


Refers to: bluetooth/tracing/BluetoothStack.wprp:1405 in 874af02. [](commit_id = 874af02, deletion_comment = False)

@arvindaiyar
Copy link
Contributor Author

i think ill just leave it as is and leave additions to you guys ... i just wanted to get the "template" up so that additions can follow the pattern.

@arvindaiyar
Copy link
Contributor Author

One more thing : the default profile if you dont specify one seems to be Verbose. I've updated the readme to reflect that.

@arvindaiyar arvindaiyar merged commit c30e0b6 into master May 24, 2018
@arvindaiyar arvindaiyar deleted the arvindaiyar/BluetoothTracingLight branch May 24, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants