This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[TypeScript][Bot-Solutions] Fix MultiProviderAuthDialog not being localized #3762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What is the context of this pull request? Why is it being done?
These changes replicate in Bot-Solution TypeScript the fix of PR #3760.
MultiProviderAuthDialog login dialog only works with the fallback language. It should be able to localize it using the user's locale.
The dialog is added in the constructor of MultiProviderAuthDialog, before the activity from the user is received, therefore the locale of the user is unknown at this moment.
This fix revolves around the idea of adding dialogs of known language beforehand, and then using the user locale to retrieve their specific locale's dialog.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
i18next
.LoginButton
andLoginPrompt
in authenticationResponses classLoginButton
andLoginPrompt
responses in authenticationResponses cardsTests
Is this covered by existing tests or new ones? If no, why not?
Unit tests passing
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General