This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Fixing inverted parameters in TokenExchangeSkillHandler.cs #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actual values for connectionName and userId parameters were inverted while invoking tokenExchangeProvider.ExchangeTokenAsync() method.
…Handler Fixing inverted parameters in TokenExchangeSkillHandler.cs
This was referenced Sep 22, 2020
peterinnesmsft
approved these changes
Oct 16, 2020
ryanisgrig
approved these changes
Oct 19, 2020
Merged
3 tasks
|
@GitDruid thanks for raising this to our attention! As we had a number of changes to work into our main branch that we needed to quickly turn around and merge latest changes from main back into each PR branch, we took your change as part of the linked #3686. Thanks again for your contribution, we greatly appreciate it! :) |
|
My pleasure to be somehow useful on this project. Ciao, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual values for connectionName and userId parameters were inverted while invoking tokenExchangeProvider.ExchangeTokenAsync() method.
Fixes #3654