Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lu parser needs to handle files over 15,000 utterances #1223

Closed
daveta opened this issue Apr 28, 2021 · 2 comments · May be fixed by #1224
Closed

lu parser needs to handle files over 15,000 utterances #1223

daveta opened this issue Apr 28, 2021 · 2 comments · May be fixed by #1224
Assignees
@hcyang
Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. P1 Painful if we don't fix, won't block releasing

Comments

@daveta
Copy link
Contributor

daveta commented Apr 28, 2021 •
edited
Loading

Versions

What CLI version are you using: 4.13.1
What OS are you using: Windows

Describe the bug

The lu parser is designed for LUIS which imposes a constraint on the number of utterances. For Orchestrator, it can handle more utterances and this limitation needs to be removed.

We have a customer (ATOS) who will run into this sooner than later.

To Reproduce

Steps to reproduce the behavior:
Run
bf luis:build --in .\lu\orch_e2e.zh-cn.lu --authoringKey ... --botName test

{
    "text": "[ERROR] 18374 utterances found in application. At most 15000 is allowed.",
    "errCode": 503,
    "diagnostics": [
        {
            "Message": "18374 utterances found in application. At most 15000 is allowed.",
            "Severity": "ERROR"
        }
    ]
}

[bug]
@daveta daveta added the P0 Must Fix. Release-blocker label Apr 28, 2021
@daveta daveta added this to the R13 milestone Apr 28, 2021
@hcyang hcyang linked a pull request Apr 28, 2021 that will close this issue
remove LUIS-specific validation logic for Orchestrator scenarios #1224
Open
@daveta daveta mentioned this issue Apr 28, 2021
Open
@sgellock sgellock modified the milestones: R13, R14 Apr 28, 2021
@sgellock
Copy link
Member

Shiproom - not taking this for R13. Moved to R14

@hcyang hcyang added backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. P1 Painful if we don't fix, won't block releasing and removed P0 Must Fix. Release-blocker labels Jun 23, 2021
@hcyang hcyang modified the milestones: R14, R15 Jun 23, 2021
@hcyang
Copy link
Contributor

hcyang commented Jun 23, 2021

This issue now depends on a successful resolution of a newly found issue: #1244.
Reduce to P1. Move it beyond R14. Bf-orchestrator-cli can consume an internal JSON input and avoid consuming LU input due to the lu-parser 15000 constraint and potential 1244 bug.

@munozemilio munozemilio removed this from the R15 milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcyang hcyang

Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove LUIS-specific validation logic for Orchestrator scenarios microsoft/botframework-cli
5 participants
@hcyang @sgellock @tracyboehrer @daveta @munozemilio