Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LU parser can generate erroneous entity output in LUIS JSON output #1244

Closed
hcyang opened this issue Jun 22, 2021 · 1 comment
Closed

LU parser can generate erroneous entity output in LUIS JSON output #1244

hcyang opened this issue Jun 22, 2021 · 1 comment
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. lu non luis api commands P0 Must Fix. Release-blocker

Comments

@hcyang
Copy link
Contributor

hcyang commented Jun 22, 2021

Versions

What CLI version are you using.
the 'main' branch

What Nodejs version are you using
v12.14.1

What command-line interpreters are you using
API

What OS are you using
Windows 10

Describe the bug

Below is the code snippet using bf-cli's LU parser and generate a LUIS JSON object. It can generate an erroneous entity label which is not specified in the input LU file.
Will share the LU input and JSON through email as the files are under NDA.

const luisBuildNoValidate: any = require('@microsoft/bf-lu/lib/parser/luis/luisCollate').build;

const luObject: any = {
  content: luContent,
  id: luFile,
};
const luisObject: any = await luisBuildNoValidate([luObject], false, '', OrchestratorHelper.findLuFiles);

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Give a clear and concise description of what you expected to happen.
LU Parser should not generate an entity label in JSON if not specified in the LU input.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

[bug]

@munozemilio munozemilio added the backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. label Sep 10, 2021
@hcyang hcyang added bug Indicates an unexpected problem or an unintended behavior. lu non luis api commands P0 Must Fix. Release-blocker and removed backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. labels Sep 20, 2021
@hcyang hcyang assigned hcyang and unassigned munozemilio Sep 20, 2021
@munozemilio
Copy link
Member

Closed by #1296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. lu non luis api commands P0 Must Fix. Release-blocker
Projects
None yet
Development

No branches or pull requests

2 participants