Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-dialogs-adaptive-runtime-core #4809

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the new ESLint errors and warnings after upgrading the ESLint packages in the botbuilder-dialogs-adaptive-runtime-core project.

Specific Changes

  • Removed the 'only-warnings' plugin from botbuilder-dialogs-adaptive-runtime-core/eslint.config.cjs' file and the related dependency.
  • Applied the auto fix flag for all the issues (trailing commas, indentation, and removal of unnecessary eslint exceptions).

Testing

The following images show the number of issues fixed in the library.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 10, 2024 14:09
@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 12257866055

Details

  • 10 of 13 (76.92%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.686%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive-runtime-core/src/serviceCollection.ts 10 13 76.92%
Totals Coverage Status
Change from base Build 12241620968: 0.0%
Covered Lines: 20528
Relevant Lines: 23085

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 671810e into main Dec 10, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-dialogs-adaptive-runtime-core branch December 10, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants