Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Node 22 #4808

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR adds support for Node 22 by fixing issues with the import-sync package and the deprecated method crypto.createDecipher.
It also updates the yaml files to include Node 22 in the testing matrix and to use this version to run the GitHub actions.

Specific Changes

  • Removed incompatible import-sync package and used tsup to compile the ESM-only dependency, filenamify.
  • Added a condition to return a descriptive error message if the legacyDecipher method is used under Node 22, because crypto.Decipher was removed.
  • Fixed unit tests in loadAndSave.tests.js to include the new error message.
  • Updated all yaml files from GitHub actions and CI pipeline to include Node 22.
  • Added the NODE_NO_WARNINGS flag in schemaMergeTest.js to avoid the execution of bf dialogs:merge to fail due to a deprecation warning.

Testing

This image shows the unit tests passing for the different supported Node versions.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 10, 2024 13:31
@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 12257176797

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 3 files are covered.
  • 17 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 84.625%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-config/src/encrypt.ts 5 9 55.56%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfiguration.ts 17 81.88%
Totals Coverage Status
Change from base Build 12241620968: -0.06%
Covered Lines: 20513
Relevant Lines: 23091

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 6751c41 into main Dec 10, 2024
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/support-node-22 branch December 10, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants