Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-ai #4790

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the new ESLint errors and warnings after upgrading the ESLint packages in the botbuilder-ai project.
Additionally, it adds the build step to the lint GitHub action to avoid import/no-unresolved errors when the eslint command runs without building the project.

Specific Changes

  • Removed 'botbuilder-ai/eslint.config.cjs' file as it contained only the 'only-warn' plugin which was no longer needed.
  • Applied the auto fix flag for most issues (spacing, trailing commas, indentation, and removal of unnecessary eslint exceptions).
  • Applied manual fixes for new rules like 'no-constant-binary-expression'.
  • Added the build step in the lint.yml file.

Testing

The following images show the number of issues fixed in the library.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner November 8, 2024 18:59
@coveralls
Copy link

coveralls commented Nov 8, 2024

Pull Request Test Coverage Report for Build 11747961433

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 84.706%

Totals Coverage Status
Change from base Build 11687414604: 0.002%
Covered Lines: 20517
Relevant Lines: 23066

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit c92f998 into main Nov 22, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-ai-package branch November 22, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants