Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#4684] Consolidate and update browser-echo-bot dependencies #4764

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR updates the browser-echo-bot dependencies to their latest version. Additionally, it consolidates the project with the rest of the botbuilder libraries with workspaces, so latest changes are taken into consideration when testing them from a bot perspective.

Specific Changes

  • Update all browser-echo-bot dependencies to their latest version.
  • Added crypto-browserify dependency to address an issue with latest botbuilder version in the browser.
  • Removed resolutions inside the browser-echo-bot, since they are no longer needed.
  • Removed the section style from the browser-echo-bot, since was causing to display the webchat incorrectly.
  • Removed browser-echo-bot yarn.lock, to consolidate the dependencies into the root's yarn.lock.
  • Updated browser-echo-bot CI pipeline to work with the new structure.

Testing

The following image shows the functional pipeline and the bot working correctly.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner October 4, 2024 20:17
@coveralls
Copy link

coveralls commented Oct 4, 2024

Pull Request Test Coverage Report for Build 11186399843

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.349%

Totals Coverage Status
Change from base Build 11164635173: 0.0%
Covered Lines: 20433
Relevant Lines: 22910

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit c88cf3b into main Oct 8, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/browser-echo branch October 8, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants