Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AdaptiveExpressions pre-built classes from Public to Internal #2658

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

cosmicshuai
Copy link
Contributor

closes: #2560
The classes in Built-in functions now are internal, except some general operation evalutor classes, like NumericEvaluator.
This is achieved by limiting the export statement in index.ts.

@cosmicshuai cosmicshuai requested a review from a team as a code owner August 6, 2020 07:49
@cosmicshuai cosmicshuai requested a review from tomlm August 6, 2020 07:49
@coveralls
Copy link

coveralls commented Aug 6, 2020

Pull Request Test Coverage Report for Build 154954

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.946%

Totals Coverage Status
Change from base Build 154951: 0.0%
Covered Lines: 14997
Relevant Lines: 17187

💛 - Coveralls

Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cosmicshuai cosmicshuai merged commit fd9ccbb into master Aug 7, 2020
@cosmicshuai cosmicshuai deleted the shuwan/changeBuiltInFuncToInternal branch August 7, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change AdaptiveExpressions pre-built classes from Public to Internal
3 participants